[Added] game-doom-id and game-freedoom filters

Moderator: GZDoom Developers

game-doom-id and game-freedoom filters

Postby Matt » Fri Sep 14, 2018 11:41 pm

(or maybe just a "doom.id" filter since we've already got "doom.freedoom")

I've got a gameplay mod that (like many others) contains a lot of little aesthetic fixes that are really specific to the original Doom and its direct descendants, e.g.:

DSSHTGN edited to remove the racking sound
POSS/SPOS/PLAY E/F sprites firing from the shoulder
various HUD weapon sprites realigned to be properly centered on the screen

All of this, of course, breaks the look and feel if loaded into Freedoom - zombies suddenly change form when they shoot, shotgun sounds are inconsistent, weapon animations don't even begin make sense.

Right now the only way to prevent this content from appearing is either:
1. put them all into doom.doom1 and doom.doom2 filters, giving us 2 copies of the exact same information in one mod; or
2. include overrides for all affected assets in the doom.freedoom filter as well, regardless of whether the Freedoom version of the thing actually calls for any sort of fix (and possibly running afoul of the GPL if I, or any other modder, am not paying specific attention to this issue).
[EDIT, for the record, what I've since been doing between this post and the addition of the filter: 3. Add a blank "id" lump to each and every one of the id game filters, and have ZScript check for that and replace sprites or actors as appropriate.]

Either option is unpleasantly bloaty and hacky.

Can we have a filter that is specific to the id IWADs, for assets that could only ever work with them and not Freedoom?
Last edited by Matt on Thu Apr 11, 2019 12:42 pm, edited 1 time in total.
User avatar
Matt
Putting the XD into *xdeath since 2007
 
Joined: 04 Jan 2004
Location: Gotham City SAR, Wyld-Lands of the Lotus People, Dominionist PetroConfederacy of Saudi Canadia

Re: game-doom-id and game-freedoom filters

Postby Matt » Tue Apr 09, 2019 5:24 pm

I'm bumping this because it occurs to me that GZDoom's own crouching player sprites have the same problem.

(Crouching sprites could be made for the Freedoom player (I'm slowly trying to work on some now) and placed in gzdoom.pk3, but they could desync at any time if anyone redoes the Freedoom sprites and doesn't realize there's this other set of related sprites in a sourceport somewhere.)
User avatar
Matt
Putting the XD into *xdeath since 2007
 
Joined: 04 Jan 2004
Location: Gotham City SAR, Wyld-Lands of the Lotus People, Dominionist PetroConfederacy of Saudi Canadia

Re: game-doom-id and game-freedoom filters

Postby Graf Zahl » Wed Apr 10, 2019 1:15 am

Unfortunately this was overlooked when the system was implemented. There definitely needs to be a "doom.id" filter.
User avatar
Graf Zahl
Lead GZDoom Developer
Lead GZDoom Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: game-doom-id and game-freedoom filters

Postby Graf Zahl » Wed Apr 10, 2019 2:16 am

Done. The new naming is "doom.id.doom1" and "doom.id.doom2", the old ones "doom.doom1" and "doom.doom2" are deprecated now.
User avatar
Graf Zahl
Lead GZDoom Developer
Lead GZDoom Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: game-doom-id and game-freedoom filters

Postby Matt » Wed Apr 10, 2019 2:19 am

Sweet, thanks!
User avatar
Matt
Putting the XD into *xdeath since 2007
 
Joined: 04 Jan 2004
Location: Gotham City SAR, Wyld-Lands of the Lotus People, Dominionist PetroConfederacy of Saudi Canadia

Re: game-doom-id and game-freedoom filters

Postby DabbingSquidward » Thu Apr 11, 2019 3:24 am

Sorry for barging in, but curiosity got the better of me. What gameplay mod are we talking about? Mind sharing a link, or is it for personal use/not finished yet?
User avatar
DabbingSquidward
Donut eat me pls!
 
Joined: 08 Nov 2017
Location: Germany
Operating System: Windows Vista/7 64-bit
Graphics Processor: nVidia with Vulkan support

Re: game-doom-id and game-freedoom filters

Postby Caligari87 » Thu Apr 11, 2019 10:29 am

I presume the mod in Question is Hideous Destructor, based on the description of the changes.

8-)
User avatar
Caligari87
I'm just here for the community
User Accounts Assistant
 
Joined: 26 Feb 2004
Location: Salt Lake City, Utah, USA
Discord: Caligari87#3089

Re: game-doom-id and game-freedoom filters

Postby dpkonofa » Sat May 25, 2019 8:33 pm

Graf Zahl wrote:Done. The new naming is "doom.id.doom1" and "doom.id.doom2", the old ones "doom.doom1" and "doom.doom2" are deprecated now.


As a point of clarification, is the deprecation notice simply intended so that mod authors going forward don't use the old filters or is the plan to actually remove support for the old filters eventually? It seems that GZDoom could probably (and likely is) detecting which syntax is being used, hence the inability to mix them, but wouldn't removing the old filters completely break older WADs?
dpkonofa
 
Joined: 25 May 2019

Re: game-doom-id and game-freedoom filters

Postby Rachael » Sat May 25, 2019 9:50 pm

Support is always maintained as long as possible. That being said, you should use the new filter name in order to ensure longevity of your mod.

As has been said dozens upon dozens of times - deprecation does NOT mean removal!
User avatar
Rachael
Webmaster
 
Joined: 13 Jan 2004
Discord: Rachael#3767
Twitch ID: madamerachelle
Github ID: madame-rachelle
Graphics Processor: nVidia with Vulkan support

Re: game-doom-id and game-freedoom filters

Postby Matt » Mon May 27, 2019 10:14 am

Freedoom is a lot more playable now than it was a few years ago, so I expect in the future partial replacement of resources targeted at id only (weapon sprite fixes, remixes of sounds, etc.) and failing to use the new filters will start getting you more "this breaks in Freedoom" complaints.
User avatar
Matt
Putting the XD into *xdeath since 2007
 
Joined: 04 Jan 2004
Location: Gotham City SAR, Wyld-Lands of the Lotus People, Dominionist PetroConfederacy of Saudi Canadia

Re: game-doom-id and game-freedoom filters

Postby deathgrip22 » Fri May 31, 2019 10:43 pm

Can somebody explain why to even have these filters and how I can make the a game using an older filter system compatible with GZDoom 4.1.2?

A texture pack I really like is messed up in Plutonia and TNT, all I can do to fix it is delete the problem-causing textures in question, but this is not a solution.
deathgrip22
 
Joined: 31 May 2019
Discord: 22deathgrip
Operating System: Windows 10/8.1/8 64-bit
Graphics Processor: nVidia (Modern GZDoom)

Re: game-doom-id and game-freedoom filters

Postby Matt » Sat Jun 01, 2019 1:52 am

There's no reason why this would break the old system - it's just deprecated not discarded.

I think it's best to post a new bug report with a link to the file in question.
User avatar
Matt
Putting the XD into *xdeath since 2007
 
Joined: 04 Jan 2004
Location: Gotham City SAR, Wyld-Lands of the Lotus People, Dominionist PetroConfederacy of Saudi Canadia


Return to Closed Feature Suggestions

Who is online

Users browsing this forum: MSN [Bot] and 3 guests