Action Special to reveal lines on automap

Moderator: GZDoom Developers

_mental_
 
 
Posts: 3812
Joined: Sun Aug 07, 2011 4:32 am

Re: Action Special to reveal lines on automap

Post by _mental_ »

Actually, I realized that the first change should have RockstarRaccoon as commiter, not me. I'll force push PR without touching changes.
User avatar
RockstarRaccoon
Posts: 598
Joined: Sun Jul 31, 2016 2:43 pm

Re: Action Special to reveal lines on automap

Post by RockstarRaccoon »

_mental_ wrote:This is how in my opinion the given feature should be implemented.
That works too. I was actually meaning to bug you about it, seeing as you've messed with this the most. What about the revealing stuff though?
Graf Zahl wrote:Regarding the line endings, what tools are you using? If it screws up the line endings it must bypass some parts of how Git processes files before committing them.
I'm using the VisualStudio setup that you guys supposedly use. It asked st some point whether to convert them to Windows or Unix, but I really wasn't sure which one you were using. Whst should it be?
User avatar
Rachael
Posts: 13531
Joined: Tue Jan 13, 2004 1:31 pm
Preferred Pronouns: She/Her
Contact:

Re: Action Special to reveal lines on automap

Post by Rachael »

Use whatever is native to your system - that's how .gitattributes is set up. So use CRLF.
_mental_
 
 
Posts: 3812
Joined: Sun Aug 07, 2011 4:32 am

Re: Action Special to reveal lines on automap

Post by _mental_ »

RockstarRaccoon wrote:What about the revealing stuff though?
There are two commits in this PR. The first one adds 'revealed' flag.
RockstarRaccoon wrote:I'm using the VisualStudio setup that you guys supposedly use. It asked st some point whether to convert them to Windows or Unix, but I really wasn't sure which one you were using. Whst should it be?
This sounds like a problem with your Git client that does checkout with Unix style line ending (LF only) on Windows.
User avatar
RockstarRaccoon
Posts: 598
Joined: Sun Jul 31, 2016 2:43 pm

Re: Action Special to reveal lines on automap

Post by RockstarRaccoon »

_mental_ wrote:This sounds like a problem with your Git client
Oh dear, he thinks I used the Git client instead of just downloading the zip... I don't have experience with Git guys, that's why the line endings are wrong. That, and Visual Studio apparently sees Unix line endings and decides I must want Windows ones...
User avatar
Rachael
Posts: 13531
Joined: Tue Jan 13, 2004 1:31 pm
Preferred Pronouns: She/Her
Contact:

Re: Action Special to reveal lines on automap

Post by Rachael »

Trial by fire is exactly how I learned to use Git, don't go thinking this trouble is unique to you. :)

Git takes a lot of personality from its creator, in that it's a stubborn little git but it'll work with you and make your life a lot easier once you know how to work with it.

https://help.github.com/articles/dealin ... e-endings/ This document basically says this will change it to properly deal with it on all repositories that don't already have it configured:

Code: Select all

git config --global core.autocrlf true
Blue Shadow
Posts: 4949
Joined: Sun Nov 14, 2010 12:59 am

Re: Action Special to reveal lines on automap

Post by Blue Shadow »

_mental_ wrote:This is how in my opinion the given feature should be implemented.
Shouldn't the udmf specs be updated as well?
User avatar
RockstarRaccoon
Posts: 598
Joined: Sun Jul 31, 2016 2:43 pm

Re: Action Special to reveal lines on automap

Post by RockstarRaccoon »

Blue Shadow wrote:Shouldn't the udmf specs be updated as well?
Do you mean the way it loads udmf files? If so, that's these 2 blocks. If you mean that the format specifications listed for GZDoom need to change, they might be holding off until this is closer to release. Someone (potentially me) still needs to program in the line_setFlag stuff.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
Posts: 49056
Joined: Sat Jul 19, 2003 10:19 am
Location: Germany

Re: Action Special to reveal lines on automap

Post by Graf Zahl »

No. The specifications file. It should contain a brief description of the new items.
Blue Shadow
Posts: 4949
Joined: Sun Nov 14, 2010 12:59 am

Re: Action Special to reveal lines on automap

Post by Blue Shadow »

Yeah, this file.
_mental_
 
 
Posts: 3812
Joined: Sun Aug 07, 2011 4:32 am

Re: Action Special to reveal lines on automap

Post by _mental_ »

UDMF spec file has a random mixture of spaces and tabs as leading indent characters. I would like to make it consistent. What’s the right indent character?
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
Posts: 49056
Joined: Sat Jul 19, 2003 10:19 am
Location: Germany

Re: Action Special to reveal lines on automap

Post by Graf Zahl »

Space. This should be printer friendly.
User avatar
drfrag
Vintage GZDoom Developer
Posts: 3141
Joined: Fri Apr 23, 2004 3:51 am
Location: Spain
Contact:

Re: Action Special to reveal lines on automap

Post by drfrag »

RockstarRaccoon wrote: Oh dear, he thinks I used the Git client instead of just downloading the zip... I don't have experience with Git guys, that's why the line endings are wrong. That, and Visual Studio apparently sees Unix line endings and decides I must want Windows ones...
Install Git for windows (i think i used default settings) and TortoiseGit. Clone the GZDoom repo, create a new branch from master and do your modifications there. In the PR target GZDoom master from your branch in your repo. Your source in your hard disk must be inside a Git repository.
User avatar
RockstarRaccoon
Posts: 598
Joined: Sun Jul 31, 2016 2:43 pm

Re: Action Special to reveal lines on automap

Post by RockstarRaccoon »

This feature request should probably be closed now. :3

https://github.com/coelckers/gzdoom/pull/485/commits
https://github.com/coelckers/gzdoom/pull/490/commits

485 added a flag to UDMF and the linedef
490 added a line special / ACS function to set it on the fly
Post Reply

Return to “Closed Feature Suggestions [GZDoom]”