[Added] More commands to safe list

Moderator: GZDoom Developers

Re: More commands to safe list

Postby drfrag » Thu Feb 15, 2018 12:34 pm

Graf Zahl wrote:CVARs represent the user's configuration. Messing around with them is at the very least considered rude behavior.

Well, no revert then. A_ZoomFactor is from 2009 so i this shouldn't be much of a problem anyway. Also i remember that screwed permanent zoomed view after playing certain mods, not nice.
User avatar
drfrag
Os voy a romper a pedazos!
Vintage GZDoom Developer
 
Joined: 23 Apr 2004
Location: Spain
Discord: drfrag#3555
Github ID: drfrag666

Re: More commands to safe list

Postby Graf Zahl » Thu Feb 15, 2018 1:03 pm

I think Operation Overlord may be adversely affected by this so a workaround would definitely be a good idea. That mod prompted me to put a fov override into my autoexec.cfg.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: More commands to safe list

Postby drfrag » Thu Feb 15, 2018 1:57 pm

How is this supposed to work? It's only a recommendation according to the text file, i'm running GZDoom with '+exec njol.cfg' and i get no zoom bindings nor menu options. No errors either even when executing njol.cfg from the console, even with an older GZDoom version.
Last edited by drfrag on Thu Feb 15, 2018 2:17 pm, edited 2 times in total.
User avatar
drfrag
Os voy a romper a pedazos!
Vintage GZDoom Developer
 
Joined: 23 Apr 2004
Location: Spain
Discord: drfrag#3555
Github ID: drfrag666

Re: More commands to safe list

Postby Graf Zahl » Thu Feb 15, 2018 2:04 pm

It's too long since this was made. My local copy has a Keyconf lump with zoom bindings but I cannot remember if they were included or made by myself.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: More commands to safe list

Postby drfrag » Thu Feb 15, 2018 2:16 pm

There's a keyconf but only setslot there. I've copied njol.cfg to autoexec.cfg and still nothing.
User avatar
drfrag
Os voy a romper a pedazos!
Vintage GZDoom Developer
 
Joined: 23 Apr 2004
Location: Spain
Discord: drfrag#3555
Github ID: drfrag666

Re: More commands to safe list

Postby drfrag » Fri Feb 16, 2018 4:56 am

To clarify things a bit Operation Overlord didn't set zoom bindings in KEYCONF, instead zoom aliases and bindings were created from njol.cfg (menu keys too). So it should work but it won't even on old versions, i wonder if this is no longer allowed from .cfg files. In that case why should it be from KEYCONF? Anyway that would be an universal zoom for all weapons even the punch so i don't find it that interesting.
User avatar
drfrag
Os voy a romper a pedazos!
Vintage GZDoom Developer
 
Joined: 23 Apr 2004
Location: Spain
Discord: drfrag#3555
Github ID: drfrag666

Re: More commands to safe list

Postby _mental_ » Fri Feb 16, 2018 6:10 am

There are no restrictions on file's content executed from console or command line.
In Operation Overlord zooming doesn't work out of the box because defaultbind's are used instead of just bind's.
_mental_
 
 
 
Joined: 07 Aug 2011

Re: More commands to safe list

Postby drfrag » Fri Feb 16, 2018 2:36 pm

I see, everything's fine then. :)
User avatar
drfrag
Os voy a romper a pedazos!
Vintage GZDoom Developer
 
Joined: 23 Apr 2004
Location: Spain
Discord: drfrag#3555
Github ID: drfrag666

Re: More commands to safe list

Postby _mental_ » Fri Feb 23, 2018 7:15 am

This branch is a proposed solution for the mentioned compatibility problem.

CVARs are no longer protected from being set in unsafe context. Although values set in such context won't be saved into .ini file.
So, mod can still do unpleasant things during the current play session but it cannot screw up user's configuration permanently.
_mental_
 
 
 
Joined: 07 Aug 2011

Re: More commands to safe list

Postby drfrag » Sat Feb 24, 2018 1:55 pm

Not everything was fine then.
User avatar
drfrag
Os voy a romper a pedazos!
Vintage GZDoom Developer
 
Joined: 23 Apr 2004
Location: Spain
Discord: drfrag#3555
Github ID: drfrag666

Re: More commands to safe list

Postby _mental_ » Wed Mar 07, 2018 1:52 pm

Workaround was added in 4053e18 +72831c9.
_mental_
 
 
 
Joined: 07 Aug 2011

Re: More commands to safe list

Postby Velma Fillerhire » Sat Sep 28, 2019 2:34 am

Returning to Aeons of Death after a decade - I see AEoD v6.06 shows critical 'Unsafe state' errors when loading from the AEoD.bat or ZDL.exe. Does this mod not work, then?
Velma Fillerhire
 

Re: More commands to safe list

Postby wildweasel » Sat Sep 28, 2019 8:43 am

Velma Fillerhire wrote:Returning to Aeons of Death after a decade - I see AEoD v6.06 shows critical 'Unsafe state' errors when loading from the AEoD.bat or ZDL.exe. Does this mod not work, then?

Does the latest release of AEoD work correctly?
User avatar
wildweasel
from a different perspective.
Moderator Team Lead
 
Joined: 15 Jul 2003

Re: More commands to safe list

Postby Levethian7 » Sat Sep 28, 2019 5:02 pm

wildweasel wrote:Does the latest release of AEoD work correctly?

I couldn't get it to work with the native .bat file or through ZDL. I assume I'm doing something wrong, but can't pinpoint it.

"Execution could not continue.
9 errors during actor postprocessing"
Levethian7
 
Joined: 28 Sep 2019
Github ID: Andrew
Operating System: Windows 10/8.1/8/201x 64-bit
Graphics Processor: nVidia (Modern GZDoom)

Re: More commands to safe list

Postby Levethian7 » Sat Sep 28, 2019 5:09 pm

Whups! Got it from the wrong source. 6.66 Alpha 8 works fine :-).
Levethian7
 
Joined: 28 Sep 2019
Github ID: Andrew
Operating System: Windows 10/8.1/8/201x 64-bit
Graphics Processor: nVidia (Modern GZDoom)

PreviousNext

Return to Closed Feature Suggestions

Who is online

Users browsing this forum: No registered users and 0 guests