Page 1 of 1

Make StatusScreen::End virtual

PostPosted: Fri Feb 09, 2018 11:04 am
by Marrub
Currently there is no way to do something when an intermission screen exits besides overriding all functions that call End(), so it would be rather convenient to be able to just override it and do stuff there.

Re: Make StatusScreen::End virtual

PostPosted: Fri Sep 14, 2018 7:30 pm
by ZippeyKeys12

Re: Make StatusScreen::End virtual

PostPosted: Fri Sep 14, 2018 7:33 pm
by Rachael
Zippey are these being properly tested before you submit them? If so, what exactly is the procedure by which you go about doing so?

I'm not saying anything's wrong with it, but you're going a bit quick with them and that concerns me.

Re: Make StatusScreen::End virtual

PostPosted: Fri Sep 14, 2018 11:14 pm
by ZippeyKeys12
I have 3 gzdoom repos on my computer, small stuff, INI parser export and per-mod storage. When one is compiling I work on the other. Once it compiles I go through all the compiler warnings to see if it is from any changes of mine. Then I make a test wad testing every function added or changed and play through map 1 of freedoom. Rinse and repeat.
The 3 PR's are for super easy stuff, that's why it was so quick.

Re: Make StatusScreen::End virtual

PostPosted: Sat Sep 15, 2018 1:28 am
by Rachael
Fair enough.

Re: Make StatusScreen::End virtual

PostPosted: Thu Sep 20, 2018 3:20 pm
by ZippeyKeys12
This can be [Added]