Make StatusScreen::End virtual
Moderator: GZDoom Developers
- Marrub
-
- Posts: 1193
- Joined: Tue Feb 26, 2013 2:48 pm
- Preferred Pronouns: No Preference
- Operating System Version (Optional): Arch Linux
- Graphics Processor: ATI/AMD with Vulkan/Metal Support
- Contact:
Make StatusScreen::End virtual
Currently there is no way to do something when an intermission screen exits besides overriding all functions that call End(), so it would be rather convenient to be able to just override it and do stuff there.
-
- Posts: 111
- Joined: Wed Jun 15, 2016 2:49 pm
Re: Make StatusScreen::End virtual
https://github.com/coelckers/gzdoom/pull/576
Let's see how this goes
Let's see how this goes
Re: Make StatusScreen::End virtual
Zippey are these being properly tested before you submit them? If so, what exactly is the procedure by which you go about doing so?
I'm not saying anything's wrong with it, but you're going a bit quick with them and that concerns me.
I'm not saying anything's wrong with it, but you're going a bit quick with them and that concerns me.
-
- Posts: 111
- Joined: Wed Jun 15, 2016 2:49 pm
Re: Make StatusScreen::End virtual
I have 3 gzdoom repos on my computer, small stuff, INI parser export and per-mod storage. When one is compiling I work on the other. Once it compiles I go through all the compiler warnings to see if it is from any changes of mine. Then I make a test wad testing every function added or changed and play through map 1 of freedoom. Rinse and repeat.
The 3 PR's are for super easy stuff, that's why it was so quick.
The 3 PR's are for super easy stuff, that's why it was so quick.
Re: Make StatusScreen::End virtual
Fair enough.
-
- Posts: 111
- Joined: Wed Jun 15, 2016 2:49 pm
Re: Make StatusScreen::End virtual
This can be [Added]