It's just a small nitpick but, if it were at least readable externally I would be able to stop effects by sector directly from ZScript, rather than have to interface with ACS (which has the added problem of being by sector tag).
Edit: Figured the best way to do this is with a getter function, gonna send in a pull request once I verify that I wrote it right.
Edit 2: The pull request is here.
Make m_Sector variable of SectorEffect readable
Moderator: GZDoom Developers
- Marisa the Magician
- Posts: 3886
- Joined: Fri Feb 08, 2008 9:15 am
- Preferred Pronouns: She/Her
- Operating System Version (Optional): (btw I use) Arch
- Graphics Processor: nVidia with Vulkan support
- Location: Vigo, Galicia
- Contact:
- Major Cooke
- Posts: 8175
- Joined: Sun Jan 28, 2007 3:55 pm
- Preferred Pronouns: He/Him
- Location: QZDoom Maintenance Team
Re: Make m_Sector variable of SectorEffect readable
Considering that it was suggested ACS functionality would be exported at some point for ZScript, this seems like a legitimate way forward. Also not needing to use TIDs all the time, and just the specific sector a thing is interested in, this will be a considerable boon.
- Graf Zahl
- Lead GZDoom+Raze Developer
- Posts: 49067
- Joined: Sat Jul 19, 2003 10:19 am
- Location: Germany
Re: Make m_Sector variable of SectorEffect readable
I'm not convinced this is the right idea. It'd be better to export the links inside the sector struct that point to the active thinkers.
- Marisa the Magician
- Posts: 3886
- Joined: Fri Feb 08, 2008 9:15 am
- Preferred Pronouns: She/Her
- Operating System Version (Optional): (btw I use) Arch
- Graphics Processor: nVidia with Vulkan support
- Location: Vigo, Galicia
- Contact:
Re: Make m_Sector variable of SectorEffect readable
Damn it, you could have said that before. I'll be right on it.