Overlay flag: PSPF_MIRROR

Moderator: GZDoom Developers

User avatar
Rachael
Posts: 13558
Joined: Tue Jan 13, 2004 1:31 pm
Preferred Pronouns: She/Her
Contact:

Re: Overlay flag: PSPF_MIRROR

Post by Rachael »

Major Cooke wrote:Softpoly is your territory, correct?
What do you mean by "territory"? It's code just as it is any other code. You're free to modify it as you see fit, as long as it falls within the scope of your PR, and in this case it most certainly does.

You might be able to ask dpJudas questions about how the player sprite code works, if you need to. :P
User avatar
Major Cooke
Posts: 8175
Joined: Sun Jan 28, 2007 3:55 pm
Preferred Pronouns: He/Him
Location: QZDoom Maintenance Team

Re: Overlay flag: PSPF_MIRROR

Post by Major Cooke »

I tried changing it and I don't know what I'm doing there. At all. So if it's a necessity, then yes. But I don't think this needs to be held back from GZDoom any further. If you take a look at the latest D4D alpha 7, you'll see I kinda need it for the left weapon... Especially try the BFG. Those offsets, man.

However if judas lends his aid, I'll gladly make another PR that addresses the softpoly side (if it's accepted before that comes around).

...How do I turn on the softpoly renderer again?
User avatar
Rachael
Posts: 13558
Joined: Tue Jan 13, 2004 1:31 pm
Preferred Pronouns: She/Her
Contact:

Re: Overlay flag: PSPF_MIRROR

Post by Rachael »

Well like I said I am not 100% sure the softpoly version of this is even needed. But having it would definitely help with getting this accepted easier.

AFAIR the psprite code is pretty much a 100% copy-paste from the Carmack version, anyway.
User avatar
Major Cooke
Posts: 8175
Joined: Sun Jan 28, 2007 3:55 pm
Preferred Pronouns: He/Him
Location: QZDoom Maintenance Team

Re: Overlay flag: PSPF_MIRROR

Post by Major Cooke »

...Well damn. I was looking in the wrong area. You're right. It is.

Done!
User avatar
Rachael
Posts: 13558
Joined: Tue Jan 13, 2004 1:31 pm
Preferred Pronouns: She/Her
Contact:

Re: Overlay flag: PSPF_MIRROR

Post by Rachael »

Looks good.
User avatar
Major Cooke
Posts: 8175
Joined: Sun Jan 28, 2007 3:55 pm
Preferred Pronouns: He/Him
Location: QZDoom Maintenance Team

Re: Overlay flag: PSPF_MIRROR

Post by Major Cooke »

Oh and Graf, if you need testing material (or missed it), this post has a sample.
User avatar
Major Cooke
Posts: 8175
Joined: Sun Jan 28, 2007 3:55 pm
Preferred Pronouns: He/Him
Location: QZDoom Maintenance Team

Re: Overlay flag: PSPF_MIRROR

Post by Major Cooke »

So here's the problem I currently face without this flag.



As you can see, the left weapons offsets are horrendously off versus the right one since the TEXTURES are all oriented around the right side of the image. Furthermore, I have to manually offset the left weapons manually. This flag will ultimately solve both issues, so I don't need to rely upon TEXTURES for flipping these things anymore and not needing to define two versions.
Last edited by Major Cooke on Fri Jun 23, 2017 12:00 pm, edited 1 time in total.
Blue Shadow
Posts: 4949
Joined: Sun Nov 14, 2010 12:59 am

Re: Overlay flag: PSPF_MIRROR

Post by Blue Shadow »

Come on, Cooke. You should know that bumping feature request threads for the purpose you did isn't a good idea.
User avatar
Major Cooke
Posts: 8175
Joined: Sun Jan 28, 2007 3:55 pm
Preferred Pronouns: He/Him
Location: QZDoom Maintenance Team

Re: Overlay flag: PSPF_MIRROR

Post by Major Cooke »

I wanted to demonstrate one of the more specific points of the problems I have, and I felt like it was justified. I would've done it at the start of this thread but I wasn't quite there yet.
User avatar
Rachael
Posts: 13558
Joined: Tue Jan 13, 2004 1:31 pm
Preferred Pronouns: She/Her
Contact:

Re: Overlay flag: PSPF_MIRROR

Post by Rachael »

This is in QZDoom and this thread should be closed if the merge is accepted.
Post Reply

Return to “Closed Feature Suggestions [GZDoom]”