0000569: Menu blur

Moderator: GZDoom Developers

Post Reply
User avatar
Nash
 
 
Posts: 17439
Joined: Mon Oct 27, 2003 12:07 am
Location: Kuala Lumpur, Malaysia
Contact:

0000569: Menu blur

Post by Nash »

https://mantis.zdoom.org/view.php?id=569

Code: Select all

Summary	0000569: Menu blur
Description	https://github.com/coelckers/gzdoom/pull/291

Can we get this addressed before the huge CS rewrite starts and this PR gets horribly out of sync? Seems like a simple enough addition...
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
Posts: 49072
Joined: Sat Jul 19, 2003 10:19 am
Location: Germany

Re: 0000569: Menu blur

Post by Graf Zahl »

I merged it to check it out but since the menu integration is quite fucked up I reset the repo.

To summarize:

- The blur is far too strong, 0.5 is already close to the acceptable maximum
- The slider does not handle the -1 (use gameinfo setting) well.
- the gameinfos should not contain any non-zero default.

If the PR gets fixed to work better, I'll merge it but this is just too rough.
User avatar
Nash
 
 
Posts: 17439
Joined: Mon Oct 27, 2003 12:07 am
Location: Kuala Lumpur, Malaysia
Contact:

Re: 0000569: Menu blur

Post by Nash »

@Graf Zahl

"since the menu integration is quite fucked up"

Can you elaborate better about this? I get the 3 things you listed but you mentioned nothing about what was wrong with the menu integration.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
Posts: 49072
Joined: Sat Jul 19, 2003 10:19 am
Location: Germany

Re: 0000569: Menu blur

Post by Graf Zahl »

The slider's values were badly chosen. In addition, with the 'use gameinfo' being lumped in with a floating point scale it is essentially broken.

dpJudas had two CVAR's for that, but Rachael merged them, which rendered it useless for menu use.
User avatar
Nash
 
 
Posts: 17439
Joined: Mon Oct 27, 2003 12:07 am
Location: Kuala Lumpur, Malaysia
Contact:

Re: 0000569: Menu blur

Post by Nash »

@Nash

Rachael isn't going to continue this so I will take her PR over. Please keep this ticket up for now, I will update her PR some time this week.
User avatar
Rachael
Posts: 13571
Joined: Tue Jan 13, 2004 1:31 pm
Preferred Pronouns: She/Her
Contact:

Re: 0000569: Menu blur

Post by Rachael »

This is in QZDoom and this thread should be closed if the merge is accepted.
Post Reply

Return to “Closed Feature Suggestions [GZDoom]”