Wall portals

Moderator: GZDoom Developers

User avatar
Major Cooke
Posts: 8059
Joined: Sun Jan 28, 2007 3:55 pm

Re: Wall portals

Post by Major Cooke »

You should probably consider trying to merge zdoom's master code as monsters were affected recently, so when and if you do go into that code, you'll be up to date.

Though honestly, it sounds like it'll just be easier spawning a new branch and moving the changes over there instead.
User avatar
ZZYZX
 
 
Posts: 1379
Joined: Sun Oct 14, 2012 1:43 am
Discord: ZZYZX#1394
Github ID: jewalky
Location: Ukraine

Re: Wall portals

Post by ZZYZX »

Monsters change doesn't sound like something that would collide with my changes, so it might be fairly easy to merge.
Although, for the same reason, I guess it isn't that important until I start working with monsters. I mean, why should I bother with updating my branch to whatever there is if it can be done anytime.

+ I don't want to spend half of my time that's dedicated to portals just to merge the stuff with the master branch.
Given that I still am not going to code this actively, and have like 4 other projects that I'm returning to time to time, so basically every time I return I'd have to do a complex merge. IMO its easier to first make a working code, and only then synchronize it with the master.
User avatar
Major Cooke
Posts: 8059
Joined: Sun Jan 28, 2007 3:55 pm

Re: Wall portals

Post by Major Cooke »

ZZYZX wrote:fairly easy to merge
Except for the big DUMB update. That and a few other updates will need you to sort through a big load of merge conflicts.

But otherwise, fair enough.
Gez
 
 
Posts: 17635
Joined: Fri Jul 06, 2007 3:22 pm

Re: Wall portals

Post by Gez »

How and why would the DUMB update cause merge conflicts? He's not touching DUMB code...
User avatar
Major Cooke
Posts: 8059
Joined: Sun Jan 28, 2007 3:55 pm

Re: Wall portals

Post by Major Cooke »

I'm saying when I had updated my repository I had a ton of merge conflicts and I was pulling from rheit/master and rebasing it too. The DUMB update just happened to be one of them.
User avatar
hfc2x
Posts: 645
Joined: Mon Aug 17, 2009 11:37 am
Location: Chule

Re: Wall portals

Post by hfc2x »

This is awesome and has been a necessary feature for ZDoom for years. Fantastic job, dude.
Spoiler:
User avatar
Tormentor667
Posts: 13458
Joined: Wed Jul 16, 2003 3:52 am
Location: Germany

Re: Wall portals

Post by Tormentor667 »

Major Cooke wrote:And a video!
Where?

Found it... this is sick O_o
User avatar
Major Cooke
Posts: 8059
Joined: Sun Jan 28, 2007 3:55 pm

Re: Wall portals

Post by Major Cooke »

Yeah, it's awesome! Oh man, I think this'll be like the scripting branch is for coders, only this is for mappers. I'm not that good of a mapper but I can still come up with some good designs with this.
User avatar
Tormentor667
Posts: 13458
Joined: Wed Jul 16, 2003 3:52 am
Location: Germany

Re: Wall portals

Post by Tormentor667 »

The question is, when will this be added to the main branch?
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
Posts: 47986
Joined: Sat Jul 19, 2003 10:19 am
Location: Germany

Re: Wall portals

Post by Graf Zahl »

Only if a) the submitter declares it ready and b) a careful review shows the code doesn't cause any serious future problems
User avatar
Major Cooke
Posts: 8059
Joined: Sun Jan 28, 2007 3:55 pm

Re: Wall portals

Post by Major Cooke »

And there is a whole lot of things on the front page ZZYZX has to go through.

(I'd be willing to wager it gets in before doomscript though. :P I know he's busy and all, but he's made quite some headway recently so who knows.)
User avatar
edward850
Posts: 5886
Joined: Tue Jul 19, 2005 9:06 pm
Location: New Zealand

Re: Wall portals

Post by edward850 »

That's quite unlikely, actually. AI understanding portals would require a pretty major rewrite of at least their sight checking routines. It's going to be a long time before that gets finished.
User avatar
Major Cooke
Posts: 8059
Joined: Sun Jan 28, 2007 3:55 pm

Re: Wall portals

Post by Major Cooke »

Hmm, yeah, I see now. That does change everything.

Who knows, such features randi has chipped in before. He might do it after the scripting branch is merged, or maybe even before. (Don't hold your breath, ZZYZX.)
User avatar
Beed28
Posts: 595
Joined: Sun Feb 24, 2013 4:07 pm
Location: United Kingdom

Re: Wall portals

Post by Beed28 »

This is amazing. Just... wow.

Antichamber clones, anybody?
User avatar
Tormentor667
Posts: 13458
Joined: Wed Jul 16, 2003 3:52 am
Location: Germany

Re: Wall portals

Post by Tormentor667 »

Image

Return to “Closed Feature Suggestions”