Include TiMidity++ in the www.zdoom.org downloads section

Moderator: GZDoom Developers

Post Reply
WilliamMacau
Posts: 62
Joined: Tue Jan 05, 2016 3:03 am

Include TiMidity++ in the www.zdoom.org downloads section

Post by WilliamMacau »

Is it possible to add TiMidity++ to the downloads section? ( I mean, does its licensing allow for? )

Also, if YES, is it possible to do even better: incorporate the timidity.exe code (timidity4zdoom I guess) into ZDOOM's code ?

Or even like Fluidsynth - a compiled DLL ???

Just asking. I know, licensing is tricky; and coding even more.
Gez
 
 
Posts: 17835
Joined: Fri Jul 06, 2007 3:22 pm

Re: Include TiMidity++ in the www.zdoom.org downloads sectio

Post by Gez »

As a DLL, it wouldn't work; when ZDoom uses it it runs it as a program, it doesn't just borrow some functions.

Incorporating TiMidity++'s code directly into ZDoom isn't possible as long as GPL-incompatible code remains present in ZDoom's codebase (this means some Build code in the renderer, the MUSLIB code for OPL playback, and the MAME OPL2 core).

Adding TiMidity++ to the download section, like Fluidsynth already is, is certainly possible, though.
WilliamMacau
Posts: 62
Joined: Tue Jan 05, 2016 3:03 am

Re: Include TiMidity++ in the www.zdoom.org downloads sectio

Post by WilliamMacau »

Oh, I see. Would be nice to have it in the downloads page, as the first time I read about it, I had to do some googlin' to find the correct forum thread where it was posted.

And it would be necessary to recompile it? I mean, after all this time, ZDoom has changend a lot. Isn't out there a more recent version of the Timidity source code ?
User avatar
Hellser
Global Moderator
Posts: 2706
Joined: Sun Jun 25, 2006 4:43 pm
Preferred Pronouns: He/Him
Operating System Version (Optional): Windows 11
Graphics Processor: ATI/AMD with Vulkan/Metal Support
Location: Citadel Station

Re: Include TiMidity++ in the www.zdoom.org downloads sectio

Post by Hellser »

Gez wrote:Incorporating TiMidity++'s code directly into ZDoom isn't possible as long as GPL-incompatible code remains present in ZDoom's codebase (this means some Build code in the renderer, the MUSLIB code for OPL playback, and the MAME OPL2 core).
Isn't there a heavily modified version of Timidity however for GUS emulation?
Last edited by Hellser on Fri Jun 03, 2016 8:09 am, edited 1 time in total.
Gez
 
 
Posts: 17835
Joined: Fri Jul 06, 2007 3:22 pm

Re: Include TiMidity++ in the www.zdoom.org downloads sectio

Post by Gez »

The GUS emulator is built on TiMidity Original Flavor™, which is LGPL. TiMidity++ had its license changed from LGPL to GPL. While the LGPL is compatible with ZDoom's [wiki=license]complex licensing mess[/wiki], the GPL isn't, so modified TiMidity is fine but TiMidity++ isn't.
WilliamMacau wrote:Oh, I see. Would be nice to have it in the downloads page, as the first time I read about it, I had to do some googlin' to find the correct forum thread where it was posted.

And it would be necessary to recompile it? I mean, after all this time, ZDoom has changend a lot. Isn't out there a more recent version of the Timidity source code ?
The download link is in the [wiki=TiMidity++]wiki article[/wiki], so google shouldn't have been needed.

The download is a standard Win32 exe, so compilation isn't needed if you use a Windows system.
WilliamMacau
Posts: 62
Joined: Tue Jan 05, 2016 3:03 am

Re: Include TiMidity++ in the www.zdoom.org downloads sectio

Post by WilliamMacau »

Well, so, isn't possible to make the built-in GUS emulator modded work with SF2 soundfonts too? It would solve this licensing issue.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
Posts: 49067
Joined: Sat Jul 19, 2003 10:19 am
Location: Germany

Re: Include TiMidity++ in the www.zdoom.org downloads sectio

Post by Graf Zahl »

No idea, but enhancing Timidity/GUS definitely low priority.
WilliamMacau
Posts: 62
Joined: Tue Jan 05, 2016 3:03 am

Re: Include TiMidity++ in the www.zdoom.org downloads sectio

Post by WilliamMacau »

MY BAD SORRY.
Last edited by WilliamMacau on Fri Jun 03, 2016 9:10 am, edited 1 time in total.
User avatar
Major Cooke
Posts: 8175
Joined: Sun Jan 28, 2007 3:55 pm
Preferred Pronouns: He/Him
Location: QZDoom Maintenance Team

Re: Include TiMidity++ in the www.zdoom.org downloads sectio

Post by Major Cooke »

You should report this in a new bug thread instead of posting a completely unrelated note.
WilliamMacau
Posts: 62
Joined: Tue Jan 05, 2016 3:03 am

Re: Include TiMidity++ in the www.zdoom.org downloads sectio

Post by WilliamMacau »

So, there's no objection to include it. :thumb:
User avatar
enderkevin13
Posts: 1383
Joined: Tue Jul 07, 2015 7:30 am
Location: :noiƚɒɔo⅃

Re: Include TiMidity++ in the www.zdoom.org downloads sectio

Post by enderkevin13 »

I'd use Coolsoft tbh, it works better and it's easier to use.
User avatar
Hellser
Global Moderator
Posts: 2706
Joined: Sun Jun 25, 2006 4:43 pm
Preferred Pronouns: He/Him
Operating System Version (Optional): Windows 11
Graphics Processor: ATI/AMD with Vulkan/Metal Support
Location: Citadel Station

Re: Include TiMidity++ in the www.zdoom.org downloads sectio

Post by Hellser »

enderkevin13 wrote:I'd use Coolsoft tbh, it works better and it's easier to use.
Maybe. But it doesn't support GUS-like patches.
User avatar
enderkevin13
Posts: 1383
Joined: Tue Jul 07, 2015 7:30 am
Location: :noiƚɒɔo⅃

Re: Include TiMidity++ in the www.zdoom.org downloads sectio

Post by enderkevin13 »

Hellser wrote:
enderkevin13 wrote:I'd use Coolsoft tbh, it works better and it's easier to use.
Maybe. But it doesn't support GUS-like patches.
True.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
Posts: 49067
Joined: Sat Jul 19, 2003 10:19 am
Location: Germany

Re: Include TiMidity++ in the www.zdoom.org downloads sectio

Post by Graf Zahl »

It looks like this has been addressed.
Post Reply

Return to “Closed Feature Suggestions [GZDoom]”