[Added] Make hidden bindings accessible from controls options

Moderator: GZDoom Developers

Make hidden bindings accessible from controls options

Postby masterkark » Sun Feb 10, 2019 5:00 am

Currently there are some key bindings that you can only remap in the .ini or console, but not in the "customize controls" GUI. These are (not sure if that's all of them though):
Code: Select allExpand view
f1=menu_help
f2=menu_save
f3=menu_load
f4=menu_options
f5=menu_display
f6=quicksave
f7=menu_endgame
f8=togglemessages
f9=quickload
f10=menu_quit
f11=bumpgamma
pad_start=pause
pad_back=menu_main

Especially quicksave and quickload would be useful to easily remap. It would be nice to be able to remap them from the actual in-game settings.
masterkark
 
Joined: 05 Feb 2019

Re: Make hidden bindings accessible from controls options

Postby m8f » Sun Feb 10, 2019 6:31 am

In case of this feature being marked as DIY, here is the DIY-implementation.
User avatar
m8f
 
 
 
Joined: 29 Dec 2017
Discord: m8f#0629
Github ID: mmaulwurff

Re: Make hidden bindings accessible from controls options

Postby Rachael » Wed Feb 13, 2019 10:14 pm

I would actually prefer that to be mainlined. Do you feel comfortable enough with Git to make that into a pull request, m8f?
User avatar
Rachael
Webmaster
 
Joined: 13 Jan 2004
Discord: Rachael#3767
Twitch ID: madamerachelle
Github ID: madame-rachelle

Re: Make hidden bindings accessible from controls options

Postby m8f » Wed Feb 13, 2019 11:27 pm

Oh, no problem, will make a PR later today.
User avatar
m8f
 
 
 
Joined: 29 Dec 2017
Discord: m8f#0629
Github ID: mmaulwurff

Re: Make hidden bindings accessible from controls options

Postby m8f » Thu Feb 14, 2019 9:32 am

I've made a PR.

What is done:
D1. Controls are separated by existing sections, each section is now a submenu;
D2. The original sections are preserved;
D3. The original controls order is preserved;
D4. "Controls" section is renamed to "Game", because "Controls" submenu of "Customize Controls" would be too confusing;
D5. Map (automap) controls are added as a section, map controls submenu is unchanged;
D6. Missing controls are added to "Other" section;
D7. Sections are given a title following the scheme "Customize [section] Controls", except N4 (see below).
D8. Inside the sections, spaces are added to group the related controls.

Things that I'm not sure about:
N1. "Game" controls section name is too generic - I'll gladly change it to something more suitable;
N2. "Other" controls section name is too generic - I'll gladly change it to something more suitable;
N3. Map controls submenu could use some spacing, and internal title ("Map Controls") is redundant;
N4. "Strife Popup Screens" section name is too long to fit in scheme described in D7, therefore the title is "Strife Popup Screens Controls";
N5. "Game" section could be divided further, but this will break the original menu structure.

I'm very open to discussion.
User avatar
m8f
 
 
 
Joined: 29 Dec 2017
Discord: m8f#0629
Github ID: mmaulwurff

Re: Make hidden bindings accessible from controls options

Postby Rachael » Thu Feb 14, 2019 9:50 am

I do support the splitting of the controls menu - the current menu we have is a bit of a clusterfuck. I haven't looked this over thoroughly yet but I have no objections from what I see so far.
User avatar
Rachael
Webmaster
 
Joined: 13 Jan 2004
Discord: Rachael#3767
Twitch ID: madamerachelle
Github ID: madame-rachelle

Re: Make hidden bindings accessible from controls options

Postby Rachael » Sat Feb 16, 2019 11:42 am

The PR got added.
User avatar
Rachael
Webmaster
 
Joined: 13 Jan 2004
Discord: Rachael#3767
Twitch ID: madamerachelle
Github ID: madame-rachelle


Return to Closed Feature Suggestions

Who is online

Users browsing this forum: Semrush [Bot] and 0 guests