Page 2 of 2
Re: [PULL REQUEST] Export FBoundingBox to ZScript
Posted: Tue Dec 11, 2018 12:50 pm
by drfrag
Rachael wrote:and it's not known or likely to cause any other issues
That's precisely the point here, oops i've reverted it anyway.
I've noticed myself that the previous "solution" was a bit shitty and now i've added a FDrawInfo* parameter to GLPortal::End.
I don't even know what outer_di is but hey if it works it works.
https://github.com/drfrag666/gzdoom/com ... 9ac12ce215
I've noticed that LZDoom is also affected by this shit, there was a similar problem in 3.3.2 and seems something i cherry-picked has made it come back.
Re: [PULL REQUEST] Export FBoundingBox to ZScript
Posted: Tue Dec 18, 2018 5:27 pm
by phantombeta
Just to be sure, are there any issues with this PR?
I'd also like to know if this is really the proper way to do this - I feel like FBoundingBox itself should be exported so it's more useful for future scriptification of actors, but I can't simply do it, since everything creates and destructs it manually.
Re: [PULL REQUEST] Export FBoundingBox to ZScript
Posted: Wed Dec 26, 2018 6:41 am
by phantombeta
I've given up on this PR due to some issues, so this can be closed.
Re: [PULL REQUEST] Export FBoundingBox to ZScript
Posted: Sun Oct 20, 2019 9:24 am
by phantombeta
It seems this thread was left open. I've closed the PR a while ago, so this should be moved to Closed Feature Suggestions. (Maybe labelled something like just "Closed")