Doom 64 style lighting improvements

Remember, just because you request it, that doesn't mean you'll get it.

Moderator: GZDoom Developers

Re: Doom 64 style lighting improvements

Postby Graf Zahl » Sun Nov 11, 2018 5:44 am

Gez wrote:How should gradients on 3D floor sides be handled? New flags in Sector_Set3dFloor?



No idea yet. We could go overkill and do it ultimately flexible or just apply the middle part flags. Let's not forget that this stuff has to be checked for each wall segment that gets rendered so some compromises will have to be made.
User avatar
Graf Zahl
Lead GZDoom Developer
Lead GZDoom Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: Doom 64 style lighting improvements

Postby Gez » Sun Nov 11, 2018 6:32 am

I figure at a minimum it should use the part of the texture that applies (control linedef's middle part by default, but upper or lower part of the actual linedef if flags 16 or 32 are set).
Gez
 
 
 
Joined: 06 Jul 2007

Re: Doom 64 style lighting improvements

Postby Graf Zahl » Sun Nov 11, 2018 7:00 am

Stuff for later. The more complicated this gets the harder it will be to do this efficiently.
User avatar
Graf Zahl
Lead GZDoom Developer
Lead GZDoom Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: Doom 64 style lighting improvements

Postby Graf Zahl » Sun Nov 11, 2018 10:06 am

Better gradient support is in. That leaves the Doom64 light model. Does anyone know how that works with depth fading? Or is it just the unattenuated colors without any fading?
User avatar
Graf Zahl
Lead GZDoom Developer
Lead GZDoom Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: Doom 64 style lighting improvements

Postby Major Cooke » Sun Nov 11, 2018 10:11 am

Can you add controls for ZScript like you did the sector glows (Sector's SetSpecialColor function)? Or are these non-runtime abilities?
User avatar
Major Cooke
Do unto others as you would have unto you. Judge yourself first.
 
Joined: 28 Jan 2007

Re: Doom 64 style lighting improvements

Postby Graf Zahl » Sun Nov 11, 2018 10:44 am

Later. That first commit was just the pure feature.
User avatar
Graf Zahl
Lead GZDoom Developer
Lead GZDoom Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: Doom 64 style lighting improvements

Postby Erick194 » Sun Nov 11, 2018 12:24 pm

I'm going to take a look at the new color options.
User avatar
Erick194
 
Joined: 10 Nov 2018
Location: Costa Rica

Re: Doom 64 style lighting improvements

Postby Erick194 » Sun Nov 11, 2018 1:38 pm

Excellent work Graf Zahl, the system to modify within the sidedefs is fine, but I think there should be at least flags for the line too, like: nogradient_all, clampgradient_all, flipgradient_top, flipgradient_mid, flipgradient_bottom.

I know that all these are in sidedefs mode, but if I want to make a sector that goes up or down I would have to configure it for both sides, it's just an idea.

Also with respect to NoGradien it could be the color of the thing, like d64.
User avatar
Erick194
 
Joined: 10 Nov 2018
Location: Costa Rica

Re: Doom 64 style lighting improvements

Postby Graf Zahl » Sun Nov 11, 2018 2:10 pm

I'd like to keep it simple for the renderer. All this stuff adds up and needs to be processed in time critical code. This is really not the place for convenience options.
There's a reason why this 'use sidedef colors' flag was added. This makes the check simple and straightforward instead of having to make guesses about the actual meaning - even though it makes editing a bit awkward. I think these things can be better managed by an editor
User avatar
Graf Zahl
Lead GZDoom Developer
Lead GZDoom Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: Doom 64 style lighting improvements

Postby drfrag » Sun Nov 11, 2018 3:12 pm

Erick194 wrote:Actually I've done several things with Gzdoom 1.9 you can see in the Doomworld forums

But you have not released your port yet nor any source code. No idea of what you've done to get the shaders working, i tried them in software with Mesa and it was somewhat playable. I was asking since i'm still maintaining an old version using the old 1.9.x renderer (ZDoom32).
Rachael wrote:Do Gallium, not SWRast. SWRast is why it is slow.

I used Gallium of course, it's still a 100% software driver.

I wonder if this will be portable to the vintage build, haven't looked at it yet, there's some stuff i need to add first. Looks i've got some work to do.
User avatar
drfrag
I.R developer, I.R smart
Vintage GZDoom Developer
 
Joined: 23 Apr 2004
Location: Spain

Re: Doom 64 style lighting improvements

Postby Rachael » Sun Nov 11, 2018 3:25 pm

If you do it, you'll have to bring back the LLVM dependency. And - interesting. I could've sworn it was hardware accelerated because it was at a playable framerate for me. I guess I got tricked. I never expected software rendered OpenGL to be that fast.

Of course, then I upped the detail settings to max just to see what it could handle and quickly discovered my frame rate tank. My fans are still spinning down from that little stunt. :twisted:
User avatar
Rachael
Webmaster
 
Joined: 13 Jan 2004
Discord: Rachael#3767
Twitch ID: madamerachelle
Github ID: madame-rachelle
Graphics Processor: nVidia with Vulkan support

Re: Doom 64 style lighting improvements

Postby drfrag » Sun Nov 11, 2018 4:04 pm

It's fast since recent versions are compiled with LLVM 6.
BTW i've recreated your old Pentium M laptop, same hardware but this one is a no brand chinese clone. :) I've adquired a hard disk for 6€ at Cex, hope it works.
drfrag wrote:I wonder if this will be portable to the vintage build, haven't looked at it yet, there's some stuff i need to add first.

I was referring to the D64 lighting of course, first i need the tarray changes. I don't know if this needs sections.
User avatar
drfrag
I.R developer, I.R smart
Vintage GZDoom Developer
 
Joined: 23 Apr 2004
Location: Spain

Re: Doom 64 style lighting improvements

Postby Erick194 » Sun Nov 11, 2018 5:02 pm

drfrag wrote: But you have not released your port yet nor any source code. No idea of what you've done to get the shaders working, i tried them in software with Mesa and it was somewhat playable. I was asking since i'm still maintaining an old version using the old 1.9.x renderer (ZDoom32).

I know, I'm almost finished with the project.

drfrag wrote: I was referring to the D64 lighting of course, first i need the tarray changes. I don't know if this needs sections.

It's a bit complicated but if possible.
User avatar
Erick194
 
Joined: 10 Nov 2018
Location: Costa Rica

Re: Doom 64 style lighting improvements

Postby drfrag » Tue Nov 13, 2018 7:00 pm

How can i test this stuff? Is there a demo around?
User avatar
drfrag
I.R developer, I.R smart
Vintage GZDoom Developer
 
Joined: 23 Apr 2004
Location: Spain

Re: Doom 64 style lighting improvements

Postby drfrag » Wed Nov 14, 2018 2:20 pm

I've just pushed this, however i don't like the idea of pushing untested stuff. The next legacy devbuild could be somewhat broken, hope it's not. Definitely needs testing, also "- cache the results of hw_FakeFlat for the remainder of the current scene instead of storing this in local variables.", "- instead of copying the sector planes to GLWall, just store pointers to the front and back sector for later use." and "- more options for Doom 64 style gradients on walls" could need some reviewing.

https://github.com/drfrag666/gzdoom/commits/legacy

Rachael wrote:I never expected software rendered OpenGL to be that fast.

About MesaForWindows recent versions are indeed much faster plus now it works, surprisingly i've tried an older version and it now works too, may be it's the nvidia driver somehow. It's strange since it's a software driver.
Edit: confirmed that only works on certain cards, else no render buffers support.
User avatar
drfrag
I.R developer, I.R smart
Vintage GZDoom Developer
 
Joined: 23 Apr 2004
Location: Spain

PreviousNext

Return to Feature Suggestions

Who is online

Users browsing this forum: No registered users and 1 guest