[Added] Make StatusScreen::End virtual

Moderator: Developers

Make StatusScreen::End virtual

Postby Marrub » Fri Feb 09, 2018 11:04 am

Currently there is no way to do something when an intermission screen exits besides overriding all functions that call End(), so it would be rather convenient to be able to just override it and do stuff there.
User avatar
Marrub
Secreta In Exile
 
 
 
Joined: 26 Feb 2013
Discord: Marrub#5455

Re: Make StatusScreen::End virtual

Postby ZippeyKeys12 » Fri Sep 14, 2018 7:30 pm

ZippeyKeys12
 
Joined: 15 Jun 2016

Re: Make StatusScreen::End virtual

Postby Rachael » Fri Sep 14, 2018 7:33 pm

Zippey are these being properly tested before you submit them? If so, what exactly is the procedure by which you go about doing so?

I'm not saying anything's wrong with it, but you're going a bit quick with them and that concerns me.
User avatar
Rachael
QZDoom + Webmaster
 
Joined: 13 Jan 2004

Re: Make StatusScreen::End virtual

Postby ZippeyKeys12 » Fri Sep 14, 2018 11:14 pm

I have 3 gzdoom repos on my computer, small stuff, INI parser export and per-mod storage. When one is compiling I work on the other. Once it compiles I go through all the compiler warnings to see if it is from any changes of mine. Then I make a test wad testing every function added or changed and play through map 1 of freedoom. Rinse and repeat.
The 3 PR's are for super easy stuff, that's why it was so quick.
ZippeyKeys12
 
Joined: 15 Jun 2016

Re: Make StatusScreen::End virtual

Postby Rachael » Sat Sep 15, 2018 1:28 am

Fair enough.
User avatar
Rachael
QZDoom + Webmaster
 
Joined: 13 Jan 2004

Re: Make StatusScreen::End virtual

Postby ZippeyKeys12 » Thu Sep 20, 2018 3:20 pm

This can be [Added]
ZippeyKeys12
 
Joined: 15 Jun 2016


Return to Closed Feature Suggestions

Who is online

Users browsing this forum: No registered users and 0 guests