User-settable UV wrapping modes for hardware shaders

Marisa the Magician · Post by **Marisa the Magician** » Mon Jul 23, 2018 4:37 am

... or just make user textures default to wrap instead of clamp. This is kind of annoying in some cases where texture coords have to be scaled/offset to achieve some effect (e.g.: scrolling overlays, detail textures). One could just use fract() to make the coordinates wrap around, but this causes visible seams when using any texture filtering mode other than None.

Post by **Graf Zahl** » Mon Jul 23, 2018 4:42 am

They should default to wrap. Is this for the newly added texture layers or also the base texture?

Marisa the Magician · Post by **Marisa the Magician** » Mon Jul 23, 2018 5:06 am

Newly-added layers.

Post by **Graf Zahl** » Mon Jul 23, 2018 7:09 am

Ok. Seems like this was overlooked.

Post by **drfrag** » Mon Jul 23, 2018 11:07 am

It doesn't compile, auto tex was declared below:

Code: Select all

C:\DEV\gzdlegacy\src\gl\renderer\gl_renderstate.cpp: In member function 'void FR
enderState::SetMaterial(FMaterial*, int, int, int, bool)':
C:\DEV\gzdlegacy\src\gl\renderer\gl_renderstate.cpp:452:6: error: 'tex' was not
declared in this scope
  if (tex->UseType == ETextureType::SWCanvas) clampmode = CLAMP_NOFILTER;
      ^~~
C:\DEV\gzdlegacy\src\gl\renderer\gl_renderstate.cpp:452:6: note: suggested alter
native: 'tell'
  if (tex->UseType == ETextureType::SWCanvas) clampmode = CLAMP_NOFILTER;
      ^~~
      tell
C:\DEV\gzdlegacy\src\gl\renderer\gl_renderstate.cpp:453:6: error: 'tex' was not
declared in this scope
  if (tex->bHasCanvas) clampmode = CLAMP_CAMTEX;
      ^~~
C:\DEV\gzdlegacy\src\gl\renderer\gl_renderstate.cpp:453:6: note: suggested alter
native: 'tell'
  if (tex->bHasCanvas) clampmode = CLAMP_CAMTEX;
      ^~~
      tell

Post by **Graf Zahl** » Mon Jul 23, 2018 1:16 pm

Damn. Moving around those lines was a late thought and not tested.

ZDoom