Countinv & max amount checks

[Ultimate Freedoomer]

Hi. As I’m sure We all know, checking a maximum amount for a jump can be done like so:

Code: Select all

A_JumpIfInventory("inventoryitem",0,offset/"state",pointer)

Of course, the main use of this is for taking backpacks into account when the jump checks for maximum amount of a clip-type ammo actor. The problem is that it doesn’t work well with anonymous functions. This is a problem with ready states that use anonymous functions &/or are animated. Basically, I’m trying to replicate this trick with countinv for situations where the ready state uses anonymous functions when animated so that it takes the backpack into account for disabling the reload button flag when the clip is full.

[Void Weaver]

Actually you can correctly perform A_JumpIfInventory inside of anon function:

Code: Select all

Ready:
SPRT 1 AB 
{
A_WeaponReady;
If(A_JumpIfInventory("inventoryitem",0,"state")){Return state("state");}
Else{Return state("");}
}
Loop

For using CountInv() in anons syntax the same but you should explicit define certain value of max amount of checked item, instead of using '0' value.

[Ultimate Freedoomer]

Actually you can correctly perform A_JumpIfInventory inside of anon function:

Code: Select all

Ready:
SPRT 1 AB 
{
A_WeaponReady;
If(A_JumpIfInventory("inventoryitem",0,"state"))
{
Return state("state");
}
Else
{
Return state("");
}
}
Loop

For using CountInv() in anons syntax the same but you should explicit define certain value of max amount of checked item, instead of using '0' value.

The Problem is that doing that with countinv is clunky when it comes to situations that would effect the capacity of the effected item unless you use a separate case to check for such things.

[Void Weaver]

What?

[Ultimate Freedoomer]

What?

I'm trying to use countinv, not a_jumpifinventory.

[Void Weaver]

For what purpose? I mean what do you want to achieve (check)? Because if you want to do check for max amount of a some item (what has been declared in OPost) ion anon f. then a_jumpifinventory is better.
Sorry if I understood something a little wrong.

[Matt]

Suppose if you wanted to see if something was maxed out, but if it was not the actual value would then be used for something else, like

int blahblah=countinv("myitem");
if (blahblah<maxinv("myitem")){
int roomtoadd=maxinv("myitem")-blahblah;
etc.
}

(not putting in the code tags to make it clear this is not real code)


I suppose you could already do this:

Code: Select all

if (!A_JumpifInventory("myitem",0,"null"){
 int blahblah=countinv("myitem");
 int maxitem=blahblah?findinventory("myitem").maxamount:getdefaultbytype("myitem").maxamount;
 int roomtoadd=maxitem-blahblah;
 //etc.
}

but that is noticeably longer and clumsier than a hypothetical "maxinv("myitem")".

Then again, one can just make that "hypothetical" function:

Code: Select all

static clearscope int MaxInv(actor holder,class<inventory> inv){
   if(holder.findinventory(inv))return holder.findinventory(inv).maxamount;
   return getdefaultbytype(inv).maxamount;
} 

[Ultimate Freedoomer]

Okay. That hypothetical function would be useful. Is there a way to add it to DECORATE/Zscript mods. Also, if I wish to submit it to the Github repository, which section of "Sri" defines "countinv"?

[Matt]

Copypaste the function into any custom class and call it from any other class with <classname>.MaxInv(...).

(I've added a "clearscope" to my previous post. Hopefully it's in the right place.)

[Ultimate Freedoomer]

Just so we're clear, when calling it from another class:

• how do I do that?
• Does it have to be an inventory class, or can it be a weapon?
• Does it have to be a zScript actor, or can I also call it from a DECORATE actor?

I'm using the ready state & the altfire from the Dump 3 weapons pack's holy water pistol as an example:

---

Code: Select all

Ready:
		HWPH A 1
		{
		If(!countinv("DUMP3HolyWater")<105&&!countinv("backpackitem")||!countinv("DUMP3HolyWater")<210&&countinv("backpackitem"))
		{
		A_WeaponReady(wrf_nosecondary);
		}
		else
		{
		A_WeaponReady(0);
		}
		return A_JumpIf(countinv("DUMP3HolyWater")<210,"AltFire");
		}
		Loop
	AltFire:
		HWPH A 1
		HWPH A 1
		{
		if(random(0,256)<64)
		{
		A_PlaySound("kinsie/zipper/down",CHAN_BODY);
		}
		a_weaponOffset(0,33);
		}
		HWPH A 1 Offset(0,35)
		HWPH A 1 Offset(0,39)
		HWPH A 1 Offset(0,44)
		HWPH A 1 Offset(0,49)
		HWPH A 1 Offset(0,55)
		HWPH A 1 Offset(0,60)
		HWPH A 1 Offset(0,70)
		HWPH A 1 Offset(0,80)
		HWPH A 1 Offset(0,90)
		TNT1 A 10
		TNT1 A 10
		{
		if(random(0,256)<64)
		{
		A_PlaySound("kinsie/vox",CHAN_VOICE);
		}
		A_PlaySound("kinsie/waterpistol/refill",CHAN_WEAPON);
		}
		TNT1 A 50
		{
		while(countinv("DUMP3HolyWater")<105&&!countinv("backpackitem")||countinv("DUMP3HolyWater")<210&&countinv("backpackitem"))
		{
		A_GiveInventory("DUMP3HolyWater",1);
		}
		a_weaponOffset(0,90);
		}
		HWPH A 1
		{
		if(random(0,256)<64)
		{
		A_PlaySound("kinsie/zipper/up",CHAN_BODY);
		}
		a_weaponOffset(0,90);
		}
		HWPH A 1 Offset(0,80)
		HWPH A 1 Offset(0,70)
		HWPH A 1 Offset(0,60)
		HWPH A 1 Offset(0,55)
		HWPH A 1 Offset(0,49)
		HWPH A 1 Offset(0,44)
		HWPH A 1 Offset(0,39)
		HWPH A 1 Offset(0,35)
		HWPH A 1 Offset(0,33)
		HWPH A 1 Offset(0,32)
		HWPH A 5
		Goto Ready
	}
}

ACTOR DUMP3HolyWater : Ammo
{
	Inventory.PickupMessage "Picked up some bottled water"
	Inventory.Amount 105
	Inventory.MaxAmount 105
	Ammo.BackpackAmount 105
	Ammo.BackpackMaxAmount 210
	Inventory.Icon "HWPAA0"
	States
	{
	Spawn:
		HWPA A -1
		Stop
	}
}

Basically, where do I insert the call for the custom function & whatnot? I just want to make sure I don't cock up.