To kill an Archangel

[Leon_Portier]

Sometimes it is necessary to kill all Archangles on a map. I´m trying to do that with ACS and ZScript, for some reason it seems to have no effect. I can confirm that the ACS Code is being run on the changing Sector color. Can one help me to see where the error is?

ACS Code

Code: Select all

script "Super_complete" (void) {

	scriptcall("ArchKiller", "FindAndKill"); //Kill all Archangles!
	Thing_Deactivate (29);
	Thing_Activate (30);
	Sector_SetColor(28,0,255,50,0);
}

ZScript code

Code: Select all

class ArchKiller : Actor {
    static void FindAndKill() {
       ThinkerIterator it = thinkeriterator.create("ArchAngel");
	   actor archie;
        while(archie == it.Next()) 
		{ 
			archie.Destroy();  
		}
    }
}

It snuggles in right there in the WAD

[Mikk-]

Maybe I'm wrong but should it not be

Code: Select all

class ArchKiller : Actor {
    static void FindAndKill() {
       ThinkerIterator it = thinkeriterator.create("ArchAngel");
      actor archie;
        while(archie = it.Next()) 
      { 
         archie.Destroy();  
      }
    }
} 

?

(you used "==" instead of "=" )

[Leon_Portier]

Thanks for the quick reply.
I did what you advised, but that seems to break it.
I get the error message that I´m trying to compare a thinker with a actor.

Code: Select all

Script error, "MAP01.wad:ZSCRIPT" line 6:
Cannot convert Pointer<Class<Thinker>> to Pointer<Class<Actor>>

line 6 is the while

Code: Select all

        while(archie = it.Next()) 

Also, in C++ to compare stuff I always used '==', maybe its different in Zscript.
Is it possible to convert it?

[Mikk-]

Ah, I see what's missing, there is class cast required:
My apologies - this snippet should work

Code: Select all

static void FindAndKill()
    {
    ThinkerIterator think = ThinkerIterator.Create("ArchAngel");
    actor mo;
    while(mo = Actor(think.Next()))
        {
        mo.Destroy();
        }
    }
 

[Leon_Portier]

Yes! It works! Thank you a lot!

[Mikk-]

No problem - mind you might not want to use mo.Destroy(); as it flat-out removes the monster from existence. Perhaps the use of mo.Die(null, null); would potentially work more in your favour?

[Matt]

The monster in question has a specific DamageMobj override that should prevent that from working. I might update it to allow a force-kill.

[Leon_Portier]

Ja, that works too!