[v0.1.1] Stupid Achievements

[f7cjo]

I can't PM, as my account is too young, here is my achievement:

Code: Select all • Expand view

class ni_departure : sa_Achievement
{
  Default
  {
    sa_Achievement.name "Early Departure";
    sa_Achievement.description "Decide it's not worth it";
    sa_Achievement.borderColor 0xA30000;
    sa_Achievement.boxColor    0xff0000;
  }
}

just a small test achievment.
Here is the ACS line that causes the crash:

Code: Select all • Expand view

ScriptCall("sa_Achiever", "achieve", "ni_departure");

I load the pk3 file with my achievement after the stupid achievements library. The achievements menu in the settings works fine.

[m8f]

Hmm. What if you change sa_Achiever.achieve signature so it looks like this:

Code: Select all • Expand view

  static
  void achieve(String achievementClass)
  {
    achievePrivate(achievementClass);
  }

in zscript/StupidAchievement.zs.

One more thing: please replace "sa_" namespace with your own.

[f7cjo]

It works now, thank you for the help.

[m8f]

Version 0.1.1 is up.
Changelog:
- fixed access to achievements from ACS.

[Laskow]

Can you teach me how to replace Imp by monsters? I expected it's very easy if I can use bIsMonster but it didn't work.

[m8f]

Do you mean how to make achievements for other monsters?

You have to add checks for monster classes. Impness is checked here. This function does the following:
1. Check if something has replaced the original imp.
2. Check if this is an imp or it's inherited from imp. ZScript has this handy construction a is "DoomImp", where a is a tested actor, and the class is after is.
3. If any of above is true, consider this thing an Imp.

When you have similar functions for other monsters (or even generalized function which takes checked monster class as a string parameter), you can use them in event functions in EventHandler (the ones with override) and give the corresponding achievements.

[Laskow]

Yes, and for all actors who used the flag "monster".

Thankfully, other monsters achievements works fine now! However, I think it's not going well actually because this code doesn't work by 2 errors:

Unknown class name 'Cultist' of type 'Actor'
Unknown identifier 'isReplacingCultist'

Code: Select all • Expand view

  private
  bool isCultist(Actor a)
  {
    bool isReplacingCultist = ("Cultist" == Actor.getReplacee(a.getClass()));
    bool isBasedOnCultist = (a is "Cultist");
    return (isReplacingCultist || isBasedOnCultist);
  }

But this one works without a hitch.

Code: Select all • Expand view

  private
  bool isCultist(Actor a)
  {
    bool isBasedOnCultist = (a is "Cultist");
    return (isBasedOnCultist);
  }

Note that the actor "Cultist" is the custom one.

[m8f]

To check for custom classes, which may or not be loaded, you need a trick: put class in a string constant, like this:

Code: Select all • Expand view

  bool isCultist(Actor a)
  {
    string cultistClass = "Cultist";
    bool isReplacingCultist = (cultistClass == Actor.getReplacee(a.getClass()));
    bool isBasedOnCultist = (a is cultistClass);
    return (isReplacingCultist || isBasedOnCultist);
  }

Again, it would be even better to move classes to function parameters entirely to prevent code duplication, like this:

Code: Select all • Expand view

  bool isMonsterClass(Actor a, string checkClass)
  {
    bool isReplacing = (checkClass == Actor.getReplacee(a.getClass()));
    bool isBasedOn = (a is checkClass);
    return (isReplacing || isBasedOn);
  }

[Laskow]

Finally it works fine.
Thank you so much for your help! I'm not an expert of ZScript so that was so helpful.