[Fixed] SPC Music No Longer Loops Properly

Bugs that have been investigated and resolved somehow.

Moderator: GZDoom Developers

SPC Music No Longer Loops Properly

Postby Simon Lightwill » Mon Nov 19, 2018 4:16 pm

This may impact other emulated musics, but this is confirmed to be affecting SPC's. Instead of playing endlessly, SPC tracks will start again from the beginning. The linked piece of music helps make this obvious: http://edthebat.com/doom/spctest.pk3

The brief musical sting should only play at the beginning, and then the song should run continuously, but now it starts again from the sting after about 20 seconds.

I can't confirm when this began, but I know GZDoom's version of GME was modified in the past few weeks, so I have suspicions about that. It is confirmed to be happening as late as Nov 19's devbuild: g3.7pre-266-g426ee2b78 (64-bit)
Simon Lightwill
 

Broken SPC music looping

Postby drfrag » Tue Dec 18, 2018 10:04 am

Since ""Update GME up to 0.6.2 version". Tested with DOOM SNES Jukebox - Ultra pack!: viewtopic.php?f=46&t=49073

Original report: viewtopic.php?f=231&t=62157&start=15#p1084022
User avatar
drfrag
I.R developer, I.R smart
Vintage GZDoom Developer
 
Joined: 23 Apr 2004
Location: Spain

Re: Broken SPC music looping

Postby Rachael » Tue Dec 18, 2018 11:19 am

viewtopic.php?f=104&t=62613

This is a duplicate, however it provides additional information. Graf, would you be opposed to me merging these two topics because I think they both independently provide additional info into the bug that the other doesn't (the other one for example has a plain example), rather than closing one off?
User avatar
Rachael
Webmaster
 
Joined: 13 Jan 2004
Discord: Rachael#3767
Twitch ID: madamerachelle
Github ID: madame-rachelle

Re: Broken SPC music looping

Postby Graf Zahl » Tue Dec 18, 2018 11:25 am

If it's the same bug they should be merged.
User avatar
Graf Zahl
Lead GZDoom Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: SPC Music No Longer Loops Properly

Postby Rachael » Tue Dec 18, 2018 11:42 am

Yeah, they are. Done.
User avatar
Rachael
Webmaster
 
Joined: 13 Jan 2004
Discord: Rachael#3767
Twitch ID: madamerachelle
Github ID: madame-rachelle

Re: SPC Music No Longer Loops Properly

Postby drfrag » Tue Dec 18, 2018 12:20 pm

Good. Wohlstand did the update so i think he's the man for the job.
User avatar
drfrag
I.R developer, I.R smart
Vintage GZDoom Developer
 
Joined: 23 Apr 2004
Location: Spain

Re: SPC Music No Longer Loops Properly

Postby _mental_ » Sat Dec 29, 2018 8:50 am

Fixed in df2bef2.
_mental_
 
 
 
Joined: 07 Aug 2011

Re: SPC Music No Longer Loops Properly

Postby Graf Zahl » Sat Dec 29, 2018 8:55 am

How did you find that?
User avatar
Graf Zahl
Lead GZDoom Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: SPC Music No Longer Loops Properly

Postby _mental_ » Sat Dec 29, 2018 9:48 am

I was searching for SPC changes in GME repository and found that commit with 'This is a behavior change' in its message. Indeed, its removal fixes the problem.
Actually, it could require some modifications in our codebase to work properly, but I have no idea how to handle it. I believe it's better to revert one commit than a whole GME update.
_mental_
 
 
 
Joined: 07 Aug 2011

Re: SPC Music No Longer Loops Properly

Postby Edward-san » Sat Dec 29, 2018 10:58 am

Why not adding a TODO comment stating this? At least it makes sure we don't miss this the next time gme is updated.
Edward-san
Mathematics is the language with which God has written the universe. (Galilei)
 
Joined: 17 Oct 2009

Re: SPC Music No Longer Loops Properly

Postby _mental_ » Sat Dec 29, 2018 11:13 am

Probably you are right. Unfortunately, this won't help much. The thing is I'm pretty sure it will be overwritten like many other custom changes in thirdparty libraries. That GME update is a good example of this, but certainly it wasn't the first one.
_mental_
 
 
 
Joined: 07 Aug 2011


Return to Closed Bugs

Who is online

Users browsing this forum: No registered users and 1 guest