[????-r2343]"Disallow suicide" is inverted

Forum rules
Please don't bump threads here if you have a problem - it will often be forgotten about if you do. Instead, make a new thread here.

Post a reply

Smilies
:D :) :( :o :shock: :? 8-) :lol: :x :P :oops: :cry: :evil: :twisted: :roll: :wink: :geek: :ugeek: :!: :?: :idea: :arrow: :| :mrgreen: :3: :wub: >:( :blergh:
View more smilies

BBCode is OFF
Smilies are ON

Topic review
   

Expand view Topic review: [????-r2343]"Disallow suicide" is inverted

Re: [????-r2343]"Disallow suicide" is inverted

by randi » Sat Jun 05, 2010 11:00 pm

Fixed.

Re: [????-r2343]"Disallow suicide" is reverted

by Edward-san » Fri Jun 04, 2010 7:22 am

After days lost to learn how to create patches (Thank you Gez), I've done a patch which seems to fix the problem. I've also changed the sv_ command, but I don't know if the ini changes it after the upgrade. Hope it helps.
BTW in the patch there is a nitpick correction if you like it.

*Waiting for the mancubus site return.
suicidefix&nitpick.zip
(1.09 KiB) Downloaded 31 times

Re: [????-r2343]"Disallow suicide" is reverted

by ZDG » Wed Jun 02, 2010 12:26 pm

Demolisher wrote: I have latest SVN,
Oh, i don't. That must be the thing.

Re: [????-r2343]"Disallow suicide" is reverted

by Edward-san » Wed Jun 02, 2010 12:31 am

Hmm ... I've checked the code, I don't know which code is wrong:
in p_interaction.cpp:

Code: Select all

		// If suiciding is disabled, then don't do it.
		if (dmflags2 & DF2_NOSUICIDE)
			return;

		// Kill the player
		Net_WriteByte (DEM_SUICIDE);
Or in m_options.cpp:

Code: Select all

	{ bitflag,	"Disallow Suicide",		{&dmflags2},	{1}, {0}, {0}, {(value_t *)DF2_NOSUICIDE} },

What about correct this comment in doomdef.h:

Code: Select all

	DF2_NOSUICIDE			= 1 << 22,	// Players are allowed to suicide.
?


[edit]Nah, not needed. It's better to change the following names IMHO:
DF2_NOSUICIDE -> DF2_SUICIDE
"Disallow Suicide" -> "Allow suicide"
sv_disallowsuicide -> sv_allowsuicide

Re: [????-r2343]"Disallow suicide" is reverted

by Xaser » Tue Jun 01, 2010 7:38 pm

I tested both, for the record. My results mirror Ed's in both cases.

Re: [????-r2343]"Disallow suicide" is reverted

by InsanityBringer » Tue Jun 01, 2010 5:38 pm

Hmm, I thought the problem was he wasn't in netgame mode. however the CVAR applies for me even if I'm in SP mode.

Re: [????-r2343]"Disallow suicide" is reverted

by Demolisher » Tue Jun 01, 2010 2:34 pm

ZDG wrote:Of course, i meant killing myself.
I have latest SVN, this bug is present, AND if I disable suicide, I cannot kill myself using the console. I have NO CLUE what this dude is smoking.

Re: [????-r2343]"Disallow suicide" is reverted

by InsanityBringer » Tue Jun 01, 2010 2:23 pm

And make sure you are in netplay mode

Re: [????-r2343]"Disallow suicide" is reverted

by Edward-san » Tue Jun 01, 2010 2:22 pm

ZDG wrote:Of course, i meant killing myself.
Hmmm.... I'm curious about this:
1)what version are you using?
1)what happens if you use the latest svn beta, if you don't?
3)what happens if you try doing a fresh install of zdoom in a different folder, then retry what I say?

[edit]may help tracking someway the broken revision[/edit]

Re: [????-r2343]"Disallow suicide" is reverted

by ZDG » Tue Jun 01, 2010 11:04 am

Of course, i meant killing myself.

Re: [????-r2343]"Disallow suicide" is reverted

by Demolisher » Mon May 31, 2010 9:49 pm

ZDG wrote:I can kill using the console both times.
You're doing it wrong.

Re: [????-r2343]"Disallow suicide" is reverted

by ZDG » Mon May 31, 2010 7:31 am

I can kill using the console both times.

Re: [????-r2343]"Disallow suicide" is reverted

by Xaser » Sun May 30, 2010 9:49 pm

Interestingly enough, I just tested this myself and the option does, indeed, seem to be reversed. Wonder how long it's been this way...

Re: [????-r2343]"Disallow suicide" is reverted

by Edward-san » Sun May 30, 2010 3:58 pm

ZDG wrote:Really? It doesn't does that to me.
When "Disallow suicide" is set to true, it means that you can't kill yourself, but in game you can die by typing "kill" in console.
When instead the option is set to false, it means that you can kill yourself, but in game you can't die by writing "kill" in console.

Re: [????-r2343]"Disallow suicide" is reverted

by ZDG » Sat May 29, 2010 9:48 am

Really? It doesn't does that to me.

Top