ZDoom

The PR was merged. This can be closed.

Fair enough.

[url=https://github.com/coelckers/gzdoom/pull/944]I've made a PR[/url] which fixes the issue. Used the same PK3 in the first post for testing to make sure.

A_BossDeath itself rightfully checks for the replacee type, but the reliance upon CheckBossDeath itself from within meant it would succeed if just that singular type alone was all dead, instead of the replaced actor type. That PR simply changes the function so it requires all replaced of the matching type to be dead, since CheckReplacee allows for assigning multiple replacees. This will finally allow for a perfect alternative and fully functioning RandomSpawner system replacement.

[quote="Major Cooke"]In particular, RandomSpawners rely upon the BOSS flag, which makes sense for cyberdemon and spider mastermind classes, but not barons, fatsos and arachnotrons.[/quote]
It looks for the BOSSDEATH flag too.

https://github.com/coelckers/gzdoom/blob/master/wadsrc/static/zscript/actors/shared/randomspawner.zs#L235:L241

while ( (other = iterator.Next ()) )
{
	if (other != actor &&
		(other->health > 0 || (other->flags & MF_ICECORPSE))
		&& other->GetClass() == actor->GetClass())
	{ // Found a living boss
		// [RH] Frozen bosses don't count as dead until they shatter
		return false;
	}
}

Load the attached file and start on MAP07 (hard skill to ensure the fatsos are randomized). Kill all of one color, and the walls will lower, which is not supposed to happen.

CheckReplacee was developed with the idea of not needing to to use RandomSpawners or any custom spawners. In particular, RandomSpawners rely upon the BOSS flag, which makes sense for cyberdemon and spider mastermind classes, but not barons, fatsos and arachnotrons.

The problematic code lies in CheckBossDeath function in p_enemy.cpp:

[code]while ( (other = iterator.Next ()) )
{
if (other != actor &&
(other->health > 0 || (other->flags & MF_ICECORPSE))
&& other->GetClass() == actor->GetClass())
{ // Found a living boss
// [RH] Frozen bosses don't count as dead until they shatter
return false;
}
}[/code]

In particular this only compares direct classes instead of checking the replacees. As seen in my example package, I have an event handler set up to indicate the replacee of Fatsos 1 & 2 to be Fatso itself.