[master] Incorrect data format for square1 iwad

Forum rules
Please don't bump threads here if you have a problem - it will often be forgotten about if you do. Instead, make a new thread here.

Post a reply

Smilies
:D :) :( :o :shock: :? 8-) :lol: :x :P :oops: :cry: :evil: :twisted: :roll: :wink: :geek: :ugeek: :!: :?: :idea: :arrow: :| :mrgreen: :3: :wub: >:( :blergh:
View more smilies

BBCode is OFF
Smilies are ON

Topic review
   

Expand view Topic review: [master] Incorrect data format for square1 iwad

Re: [master] Incorrect data format for square1 iwad

by Edward-san » Wed Nov 23, 2016 3:23 am

They lack the newline. PR here.

Re: [master] Incorrect data format for square1 iwad

by Graf Zahl » Wed Nov 23, 2016 3:14 am

I clarified the error message, but obviously can't do much about the fact that the maps indeed contain garbage data that should be warned about.

Re: [master] Incorrect data format for square1 iwad

by Graf Zahl » Mon Nov 21, 2016 2:08 pm

The message is from a time when these lumps were only named SCRIPTxx.

Re: [master] Incorrect data format for square1 iwad

by Edward-san » Mon Nov 21, 2016 1:46 pm

Uh okay...

still, the message could be improved, like mentioning it's a conversation lump problem (just saying 'Incorrect format data' is misleading)...

Re: [master] Incorrect data format for square1 iwad

by Gez » Mon Nov 21, 2016 1:27 pm

Doom Builder tends to add garbage DIALOGUE lumps in UDMF.

Re: [master] Incorrect data format for square1 iwad

by Graf Zahl » Mon Nov 21, 2016 1:05 pm

Do these maps contain conversation scripts? And if so, are they there by intent or just some garbage?

Re: [master] Incorrect data format for square1 iwad

by Edward-san » Mon Nov 21, 2016 12:53 pm

All the errors I see come from the failed condition:

Code: Select all

// Strife scripts are always a multiple of 1516 bytes because each entry
// is exactly 1516 bytes long.
if (numnodes % 1516 != 0)
And as I said, it happens with most of the maps:

maps/titlemap.wad , maps/e1a3.wad, maps/e1a4.wad, maps/e1a5.wad, maps/e1a7.wad, maps/e1a9.wad, maps/e1a10.wad, maps/training.wad, maps/dm01.wad, maps/dm02.wad, maps/dm03.wad, maps/dm04.wad

Re: [master] Incorrect data format for square1 iwad

by Graf Zahl » Mon Nov 21, 2016 12:48 pm

That message means that the conversation script loader failed to detect the format for a lump. No idea what's wrong since you left out the most important part for analyzing the problem, i.e. the actual lump name. I can't test right now so I at least need to know what to look at.

[master] Incorrect data format for square1 iwad

by Edward-san » Mon Nov 21, 2016 12:42 pm

If you load square1.pk3 (be sure to use at least version 1.3.2 (2016-10-06) from the website), some maps exhibit this warning:

Code: Select all

Incorrect data format for maps/%name of the map.wad%.
I can say that, to be pedantic, the DPrintf calls in p_conversation.cpp lack the newline. And also a clearer description of the problem.

Anyways, is it a problem with the iwad or with zdoom?

Top