Scaling issues on translucent, wrapped midtextures

Forum rules
Please don't bump threads here if you have a problem - it will often be forgotten about if you do. Instead, make a new thread here.

Post a reply

Smilies
:D :) :( :o :shock: :? 8-) :lol: :x :P :oops: :cry: :evil: :twisted: :roll: :wink: :geek: :ugeek: :!: :?: :idea: :arrow: :| :mrgreen: :3: :wub: >:( :blergh:
View more smilies
BBCode is OFF
Smilies are ON
Topic review
   

Expand view Topic review: Scaling issues on translucent, wrapped midtextures

Re: Scaling issues on translucent, wrapped midtextures

by Graf Zahl » Sat Nov 05, 2016 3:06 am

Looks correct, no apparent performance hit, and getting rid of some Build code. Can it get any better...? ;)

Re: Scaling issues on translucent, wrapped midtextures

by dpJudas » Fri Nov 04, 2016 11:54 pm

Ah, but you've been looking at the new wallscan function for quite a while in QZDoom. It, and my earlier truecolor branch, has been using it there for 6 months soon in both pal and true color.

One of its changes in an ocean of changes! ;)

Re: Scaling issues on translucent, wrapped midtextures

by Rachael » Fri Nov 04, 2016 11:13 pm

It's to test to see if the midtex is clipped through the floor, or if it is rendered through the floor. The sprites I didn't need to test, because they were still going through the floor just fine.

I dunno - like I said I randomly invented it. I just wanted to be sure the new wall drawers worked as expected.

You could say, everything went swimmingly in that test. ;)

Okay, okay, I'll stop.

Re: Scaling issues on translucent, wrapped midtextures

by dpJudas » Fri Nov 04, 2016 10:48 pm

Hmm, not sure what that wad tests exactly. :) One thing that strikes me as a little odd, though, is that the vertical position of the marine is further up when seen from the front.

Re: Scaling issues on translucent, wrapped midtextures

by Rachael » Fri Nov 04, 2016 10:23 pm

Just to be sure, I trialed your fix through the swimming marine test. Something I randomly invented for the purposes of testing the wall masking drawer. :P

It passed. :P
Attachments
swimming-marine-test.wad
(1.49 KiB) Downloaded 38 times

Re: Scaling issues on translucent, wrapped midtextures

by dpJudas » Fri Nov 04, 2016 9:07 pm

Alright, here's the pull request with my rewritten wallscan: https://github.com/rheit/zdoom/pull/892

Note that if you merge this, wallscan/maskwallscan/transmaskwallscan can be removed from the list of build dependencies on the wiki.

Re: Scaling issues on translucent, wrapped midtextures

by Gez » Fri Nov 04, 2016 10:38 am

All the more reason to get rid of it, IMO.

Re: Scaling issues on translucent, wrapped midtextures

by Graf Zahl » Fri Nov 04, 2016 8:23 am

Well, the code originates from Build, I think that says it all...

Re: Scaling issues on translucent, wrapped midtextures

by dpJudas » Fri Nov 04, 2016 6:27 am

Honestly, I don't know how well it competes with the original. I don't know if the original did it in such a convoluted way for some speed reason, or just to make it complicated for itself. With code one never knows. :)

Re: Scaling issues on translucent, wrapped midtextures

by Graf Zahl » Fri Nov 04, 2016 6:21 am

That's definitely worth a try. That is, unless it affects performance too much.
On the other hand, getting rid of that mess of code would definitely be an advantage.

Re: Scaling issues on translucent, wrapped midtextures

by dpJudas » Fri Nov 04, 2016 6:18 am

Interesting. This doesn't seem to be happening in QZDoom: http://imgur.com/a/77KIw (top image true color, bottom palette)

That means it must be an issue with wallscan, which I rewrote in QZDoom to fix a buffer overrun situation. I can't really fix the current wallscan, its code is too cryptic to me, but I can backport my rewritten wallscan to ZDoom if you'd like.

Re: Scaling issues on translucent, wrapped midtextures

by Graf Zahl » Fri Nov 04, 2016 4:54 am

Yes, looks exactly the same.

Re: Scaling issues on translucent, wrapped midtextures

by Edward-san » Fri Nov 04, 2016 4:51 am

Could it be the same as the one in Daedalus map25 at coordinates 227 -1713 on the right side?

Re: Scaling issues on translucent, wrapped midtextures

by Graf Zahl » Fri Nov 04, 2016 4:22 am

This looks like something for dpJudas. It's still present in the latest build as of today.

Scaling issues on translucent, wrapped midtextures

by InsanityBringer » Sat Oct 01, 2016 8:45 pm

Sample map, and a screenshot (but really it doesn't show you much, the bug generates absolute noise)

I've been noticing in recent dev builds (since the FP rewrite most likely, as it looks alright in ZDoom 2.8.1) that some maps like a few KDIZD maps from what I remember, which use translucent midtextures, if they enable the "wrap midtexture" flag on the line, the texture is scaled horribly to the point where its an absolute moirefest. The sample wad demonstrates this, with one line using wrapped midtextures and no translucency, while the other has wrapped midtextures and translucency. When rendered in recent builds of ZDoom (I tested the latest one for this), the translucent one exhibits the scaling artifacts, while the opaque one doesn't.

From further testing, translucent midtextures are fine. Its just wrapped ones that aren't.

Top