[HEAD, Linux, X86] Zdoom + SmoothDoom.pk3 crash on exit

Forum rules
Please don't bump threads here if you have a problem - it will often be forgotten about if you do. Instead, make a new thread here.

Post a reply

Smilies
:D :) :( :o :shock: :? 8-) :lol: :x :P :oops: :cry: :evil: :twisted: :roll: :wink: :geek: :ugeek: :!: :?: :idea: :arrow: :| :mrgreen: :3: :wub: >:( :blergh:
View more smilies
BBCode is OFF
Smilies are ON
Topic review
   

Expand view Topic review: [HEAD, Linux, X86] Zdoom + SmoothDoom.pk3 crash on exit

Re: [HEAD, Linux, X86] Zdoom + SmoothDoom.pk3 crash on exit

by vanfanel » Mon Oct 10, 2016 2:50 am

Confirmed here it's fixed too!! :D

Re: [HEAD, Linux, X86] Zdoom + SmoothDoom.pk3 crash on exit

by Matt » Thu Oct 06, 2016 11:21 pm

Confirmed is fixed! \o/

Re: [HEAD, Linux, X86] Zdoom + SmoothDoom.pk3 crash on exit

by Graf Zahl » Thu Oct 06, 2016 5:11 am

Yes, that's what I expected. The old code was a hopeless affair of trying to delete a linked list, while every element in that list also tried to manipulate the list while being deleted. It was so messy that I had problems tracking down which code was actually doing what in there.

Re: [HEAD, Linux, X86] Zdoom + SmoothDoom.pk3 crash on exit

by Edward-san » Thu Oct 06, 2016 4:42 am

It stopped crashing for me and the valgrind output is more clean now.

Re: [HEAD, Linux, X86] Zdoom + SmoothDoom.pk3 crash on exit

by Graf Zahl » Thu Oct 06, 2016 12:53 am

Can be, because since P_BringUpWeapon is in the call trace and that won't be called if the weapon is already being raised or lowered.

Can you please retry with my latest commit? The destruction of the inventory list was heavily littered with side effects, so I went the extra route of cleaning all the inventory links before destroying the items, making sure that they no longer are in a list or linked to an owner. Normally this should be enough to fix this problem.

Re: [HEAD, Linux, X86] Zdoom + SmoothDoom.pk3 crash on exit

by Matt » Wed Oct 05, 2016 11:23 pm

Is it just me or does the crash not happen when you exit while your weapon is in a raising or lowering state?

Re: [HEAD, Linux, X86] Zdoom + SmoothDoom.pk3 crash on exit

by Matt » Wed Sep 28, 2016 12:10 am

Was playing HD running around with the chainsaw on map01, quit, no crash but got this:

Code: Select all

*** Error in `/home/mchan223/doom/./gzdoom': corrupted double-linked list: 0x0000000002f57770 ***
Related?

Re: [HEAD, Linux, X86] Zdoom + SmoothDoom.pk3 crash on exit

by Matt » Tue Sep 27, 2016 1:02 am

I seem to be getting this with pretty much every pk3 or folder weapon mod except ww-doomnukem and Demonsteele while playing as Shihong (while spawning as Hae-Lin results in the crash). No idea why those two are fine.

EDIT:
On the HD thread, Hetdegon wrote:...but it's a bit painful when changing options as it doesn't save the changes.
Is this at all helpful as a lead? Maybe something to do with saving configuration settings on exit? (I'm taking a wild guess that it might be related to how and where this stuff is saved, which is why there's no problem in Windows)

Re: [HEAD, Linux, X86] Zdoom + SmoothDoom.pk3 crash on exit

by Hetdegon » Tue Sep 20, 2016 2:13 am

Hey, just to confirm, I get this issue too, although it seems to happen with pretty much anything. It's not much of a problem for regular usage except it never gets to save config changes. The error I get is exactly the same as the first post (using gzdoom, current git 2.3pre on ubuntu 64b). Should I post a log and extra info for reference?

Re: [HEAD, Linux, X86] Zdoom + SmoothDoom.pk3 crash on exit

by Edward-san » Wed Sep 14, 2016 11:26 am

This should be moved back to 'Bugs' section, since the original issue is not yet fixed.

Re: [HEAD, Linux, X86] Zdoom + SmoothDoom.pk3 crash on exit

by Edward-san » Tue Sep 13, 2016 2:02 pm

Now valgrind is clear, but I guess running with '-norun' doesn't show the issue shown by the crash report in OP. See the attached valgrind's result with this zdoom command line:

Code: Select all

zdoom -iwad DOOM2.WAD -file SmoothDoom.pk3 -warp 01 -nosound
then open menu and quit.

I had to zip it because the output is too big...

(also I removed some valgrind output which can be reproduced also without SmoothDoom.pk3)
Attachments
valgrind_smoothdoom.zip
(5.27 KiB) Downloaded 29 times

Re: [HEAD, Linux, X86] Zdoom + SmoothDoom.pk3 crash on exit

by Graf Zahl » Tue Sep 13, 2016 1:02 pm

Ok, seems like there was another possibility to call FindName in there. Should be fixed now.

Re: [HEAD, Linux, X86] Zdoom + SmoothDoom.pk3 crash on exit

by JPL » Tue Sep 13, 2016 12:42 pm

My (x86-64) system has GCC 6.2.1 20160830 and GZDoom + SmoothDoom doesn't crash on exit when compiled with that.

Re: [HEAD, Linux, X86] Zdoom + SmoothDoom.pk3 crash on exit

by Edward-san » Tue Sep 13, 2016 12:02 pm

The crash didn't change much:
Spoiler:

Re: [HEAD, Linux, X86] Zdoom + SmoothDoom.pk3 crash on exit

by Graf Zahl » Tue Sep 13, 2016 10:58 am

I do not use Linux, so no.

Top