ZDoom

Made a new [url=https://github.com/rheit/zdoom/pull/569]pull request[/url] to restore the previous frame letter.

Yes, it does. It should be what it was before.

Does DeHackEd not get the frames from the DECORATE definition? That was my concern over changing the F to an A.

Yes, but since it jumps to a PAIN A frame, even less.

[quote="Graf Zahl"]A zero-duration frame will never be displayed so it's completely irrelevant if it is brighr or not[/quote]
So it's likewise irrelevant that the A_PainAttack state is (at the moment) 'PAIN A' rather than 'PAIN F'?

No. A zero-duration frame will never be displayed so it's completely irrelevant if it is brighr or not (or if a dynamic light is attached to it.)

Quick question: is there ever a point to putting the BRIGHT keyword on a 0-tic frame, other than DeHackEd compatibility? I see it happen sometimes and I'm curious.

For that matter, shouldn't that fix have used PAIN F 0 BRIGHT so DeHackEd uses the expected sprite index?

I hope that's everything now.

{SPR_PAIN,32773,0,{A_PainAttack},S_PAIN_RUN1,0,0},   // S_PAIN_ATK4

PAIN A 0 BRIGHT A_PainAttack

I have a question: should this:

[code]
{SPR_PAIN,32773,0,{A_PainAttack},S_PAIN_RUN1,0,0}, // S_PAIN_ATK4
[/code]

be converted to:

[code]
PAIN A 0 BRIGHT A_PainAttack
[/code]
or should I use 'PAIN F 0'?


[edit] Whatever, I used the former version, then made this [url=https://github.com/rheit/zdoom/pull/568]pull request[/url] fixing both pain elemental and mancubus.

The thread Gez also lists an incorrect behavior with the Mancubus states...

    {SPR_PAIN,32773,5,{A_FaceTarget},S_PAIN_ATK4,0,0},	// S_PAIN_ATK3
    {SPR_PAIN,32773,0,{A_PainAttack},S_PAIN_RUN1,0,0},	// S_PAIN_ATK4

Seems to be confirmed:

from chocolate-doom/src/doom/info.c:
[code]
{SPR_PAIN,32773,5,{A_FaceTarget},S_PAIN_ATK4,0,0}, // S_PAIN_ATK3
{SPR_PAIN,32773,0,{A_PainAttack},S_PAIN_RUN1,0,0}, // S_PAIN_ATK4
[/code]

though if I were nitpicky I'd post it in another bug report :P .

I noticed a similar discrepancy with the Pain Elemental's Missile state frames. If what I'm told about vanilla is correct, the third call to A_FaceTarget should be five tics, not four, and A_PainAttack should be zero tics.

See [url=https://www.doomworld.com/vb/doom-general/86141-exact-revenant-behaviour/]thread[/url]. The revenant's melee state should last 0 tics.

[url=https://github.com/rheit/zdoom/pull/567]Convenient pull request[/url] so it can be fixed in a couple of clicks.