ZDoom

[quote="Graf Zahl"]No. Only for the standard weapons, because those were all made for the duplicated frame.[/quote]
Ah, alright, thanks for clarification.

No. Only for the standard weapons, because those were all made for the duplicated frame.

Wait what, so you reverted the fix to flashes being processed in 2 tics? If so, shit... (I had adapted a lot of my mods to it, being able to define 1-tic flashes is extremely useful.)

I hope this is fixed now. For the attack functions that also set the flash I especially disabled the check causing the problem, but I left A_GunFlash alone - even though I wouldn't mind removing this ill-informed bit of code - which should have opt-in and not unconditional. It just escapes me how this got added without ever checking what it implied.

Huh, I wouldn't be surprised if this was the thing that broke Parkour's dual wielding a while back. I reuploaded the mod with a fix afterward; I wonder if I"ll need to re-reupload it. :P

Normally I'd vote for such a fix to be opt-in via flag, but I'll bet there's a bunch of stuff floating around (e.g. above) that relies on the new behavior now. :/

And here we got the corresponding bug report:

http://forum.zdoom.org/viewtopic.php?f=7&t=31689

The fix apparently went too far and should have left the original weapon functions alone.

Oh, no. Please don't tell me that some external patch got applied that made an uninformed and unconditional change to established behavior. Stuff like this needs to be toggleable.

I addressed the same issue some years ago: [url]http://forum.zdoom.org/viewtopic.php?f=4&t=33036[/url]
But I couldn't test my suggested changes because I never managed to compile the source code (due to me missing essential files that I couldn't find), so I just gave up.
Still, I hope this sheds some light on the issue.

I'd like to see an explanation of the bug, because from a cursory glance at the vanilla P_SetPsprite() I don't see anything that would shorten flash states specifically.

[quote="Minigunner"]The fix should really only occur on the first shot, considering how Doom treats the first frame in a state; otherwise, in the event of a ReFire, there should be no fix.[/quote]
I'm not seeing this behavior. Do you have an example/evidence?

At any rate, here's a simple test case for the wider issue -- a chaingun with its Fire and Flash states set to 1 tic:
[attachment=0]chainfun.zip[/attachment]
In ZDoom you get a flash; in Vanilla you do not (as the effective length is now 0 tics).

Interestingly, id knew about this and just adjusted the state tables, hence why Doom weapons have the flash states go a bit longer than they look like they should. The chaingun again is the best example; the firing states are 4 tics, while the flash states are 5 tics. In 'nilla you get a perfectly-synced animation, while in ZDoom you see this briefly:
[url=http://i.imgur.com/DHfy2XWl.png][img]http://i.imgur.com/DHfy2XWt.png[/img][/url]


tl;dr: yes, the issue exists, even if it's unnoticeable to some folks. :P

The fix should really only occur on the first shot, considering how Doom treats the first frame in a state; otherwise, in the event of a ReFire, there should be no fix.

I noticed these, but I'm not too bothered about them to the point I want them "fixed" by ZDoom. Heck, most of the time when playing I have one of those smooth animation mods loaded.

I noticed that it doesn't seem to last any longer than it should in Chocolate Doom.

[quote="Graf Zahl"]Have you read my post?[/quote]
Yup. I meant that in jest to clarify.

Have you read my post?

What I'd do is add a new weapon flag that's only being used on the original Doom weapons and then make sure that their flash states have the same duration as the original state tables.
And then, if it becomes necessary, add a compatibility option to switch this off - but only if proof can be given that this is necessary.