A_SpawParticles (X,Y,Z,XYZSpeeds,Color)

Post a reply

Smilies
:D :) :( :o :shock: :? 8-) :lol: :x :P :oops: :cry: :evil: :twisted: :roll: :wink: :geek: :ugeek: :!: :?: :idea: :arrow: :| :mrgreen: :3: :wub: >:( :blergh:
View more smilies
BBCode is OFF
Smilies are ON
Topic review
   

Expand view Topic review: A_SpawParticles (X,Y,Z,XYZSpeeds,Color)

Re: A_SpawParticles (X,Y,Z,XYZSpeeds,Color)

by Major Cooke » Thu Jan 21, 2016 5:28 pm

Let's put all future discussion here.

Re: A_SpawParticles (X,Y,Z,XYZSpeeds,Color)

by Major Cooke » Thu Jan 21, 2016 5:23 pm

I took a gander at the ACS version for changing the alpha and fadestep... No idea on how to handle those.

Re: A_SpawParticles (X,Y,Z,XYZSpeeds,Color)

by NeuralStunner » Thu Jan 21, 2016 5:23 pm

edward850 should have wrote:I picked a bad day to change my coffee.
:P

Re: A_SpawParticles (X,Y,Z,XYZSpeeds,Color)

by edward850 » Thu Jan 21, 2016 5:21 pm

Major Cooke wrote:Actually I specified it's for DECORATE only. The relativity is only for actors, and the ACS version has none to deal with. Just a set of coordinates.
I am completely off the ball this morning or something. Perhaps I shouldn't have changed my coffee...

Re: A_SpawParticles (X,Y,Z,XYZSpeeds,Color)

by Major Cooke » Thu Jan 21, 2016 5:18 pm

edward850 wrote:You completely forgot the ACS function. :P
As for fadestep, change ACTION_PARAM_INT(fadestep, 11) to a fixed and scale it just like startalpha. Perhaps the same should be done for the ACS function for consistency.
Actually I specified it's for DECORATE only. The relativity is only for actors, and the ACS version has none to deal with. Just a set of coordinates.

Okay, doing that now. Not sure what to do for the ACS version though, for changing that.

Re: A_SpawParticles (X,Y,Z,XYZSpeeds,Color)

by edward850 » Thu Jan 21, 2016 5:09 pm

Somehow I completely missed that despite looking right at it. Silly me. :P

Re: A_SpawParticles (X,Y,Z,XYZSpeeds,Color)

by Graf Zahl » Thu Jan 21, 2016 5:08 pm

edward850 wrote: Also I noticed you changed startalpha to fixed, but never changed what that means to P_SpawnParticle, which still takes a byte (because the particle internally takes a byte).
Uh, what?

Code: Select all

	BYTE startalpha = (BYTE)Scale(clamp(startalphaf, 0, FRACUNIT), 255, FRACUNIT);

Re: A_SpawParticles (X,Y,Z,XYZSpeeds,Color)

by edward850 » Thu Jan 21, 2016 4:53 pm

Graf Zahl wrote:Does it? Can you explain what this parameter is there for?
Controls the fade out of each tic, basically. Internally it's usually set to 255/lifetime. Also I noticed you changed startalpha to fixed, but never changed what that means to P_SpawnParticle, which still takes a byte (because the particle internally takes a byte).
Major Cooke wrote:edward850: if you can tell me what to change, I'll throw it in here.
You completely forgot the ACS function. :P
As for fadestep, change ACTION_PARAM_INT(fadestep, 11) to a fixed and scale it just like startalpha. Perhaps the same should be done for the ACS function for consistency.

Re: A_SpawParticles (X,Y,Z,XYZSpeeds,Color)

by Major Cooke » Thu Jan 21, 2016 4:44 pm

edward850: if you can tell me what to change, I'll throw it in here.

Re: A_SpawParticles (X,Y,Z,XYZSpeeds,Color)

by Graf Zahl » Thu Jan 21, 2016 4:44 pm

Does it? Can you explain what this parameter is there for?

Re: A_SpawParticles (X,Y,Z,XYZSpeeds,Color)

by edward850 » Thu Jan 21, 2016 4:15 pm

Graf Zahl wrote:Looking through this, I think I'm going to change the alpha parameter of the DECORATE version from byte to float for consistency. So please no hurry with the docs... ;)
You didn't want to do this with fadestep as well, which directly relates to the starting alpha?

Re: A_SpawParticles (X,Y,Z,XYZSpeeds,Color)

by D2JK » Thu Jan 21, 2016 1:00 pm

No, it wouldn't. You do not want one random number for all, you want different numbers, and for those you need the min and max.
Your comment was a bit hard to decipher at first, but I assume you are referring to each random value being randomized only once per function call. If so, I see what you mean.

Re: A_SpawParticles (X,Y,Z,XYZSpeeds,Color)

by Major Cooke » Thu Jan 21, 2016 12:46 pm

Graf Zahl wrote:Looking through this, I think I'm going to change the alpha parameter of the DECORATE version from byte to float for consistency. So please no hurry with the docs... ;)
What about a relative flag? Something to make it like A_SpawnItemEx's relativity, or akin to A_ChangeVelocity's RELATIVE flag.

Re: A_SpawParticles (X,Y,Z,XYZSpeeds,Color)

by Hellser » Thu Jan 21, 2016 12:39 pm

I can't wait to use this. Oh, this is going to be so deliciously good!

Re: A_SpawParticles (X,Y,Z,XYZSpeeds,Color)

by Graf Zahl » Thu Jan 21, 2016 12:34 pm

Looking through this, I think I'm going to change the alpha parameter of the DECORATE version from byte to float for consistency. So please no hurry with the docs... ;)

Top