ZDoom

Done.

MajorCooke: Please cancel the PRs you made for this. My backport is not complete (I just checked) and I will re-do it properly.

Nash and I were asking if there were any issues with the code so far. While it may work for our ends, we cannot be sure Graf will be happy with the implementation.

I also wouldn't be surprised if this took even longer due to the recent revert.

From a stubborn semi-dev's perspective: "Hey, is this done yet?" is a surefire way to make me [i]not[/i] want to work on a feature.

I would very much like to hear about this too.

Graf Zahl: Any feedback? Was the code bad?

Roughly liky Phantom, I wound up just making a remote to GZDoom in my ZDoom, made a new branch off of GZDoom's latest commit and called it a day after implementing the code. Couldn't be arsed to go through the pain anymore because I couldn't get the pull requests to work.

[spoiler][img]http://puu.sh/kcOUY/3130a1cf24.png[/img][/spoiler]

This worked, though switching between the branches requires cleaning out a few things (just the gltext stuffs). Was simple though. I then went to Graf's gzdoom github page and had the pull request made there with the code changes.

I can't remember exactly what to do, but I think this should work:
[list]
[*]Create a new empty repo in SmartGit. (Don't link it to the GitHub repo yet.)
[*]Add ZDoom's repo as a new remote. (Remote>Add...)
[*]Pull everything from the new remote. (Right click the remote in the branches view then click "Pull...")
[*]Double click the branch you want to make a pull request for in the Branches view to checkout the branch.
[*]It should now ask if you want to create a local branch or not.
[*]Choose "Create local branch".
[*]Add a new branch with the name you want. (Branch>Add Branch... or F7)
[*]Add a new remote with the name "origin" and link it to your fork of the GZDoom repo.
[*]Push the branch. (There should be a big "Push" button in the main view) When it asks you what to do, click "Configure".
[*]The origin remote (Your GitHub repo) should now have a new branch that is up to date with the branch you're making the pull request for.[/list]
Make your changes, commit and push like normal. You should be able to use TortoiseGit after the last step.
To make a new branch for a pull request, do it again from step 3. (Skip step 8)
To make the pull request for ZDoom, go to the main page of the GitHub repo. It should show the new branches. Click the "Compare & Pull Request" button next to the branch you want and make the pull request.
In the "Comparing changes" page, change the "Base" branch to the one you want to make a pull request for.

[quote="phantombeta"]@Nash
I don't use the command-line. I use SmartGit.[/quote]

Okay then can you describe the exact process you go through with SmartGit, please? Thanks.

@Nash
I don't use the command-line. I use SmartGit.

[quote="phantombeta"]I don't use TortoiseGit, so... *shrugs*[/quote]

Please give me the exact command lines you use, then.

https://github.com/rheit/zdoom/pull/377
https://github.com/coelckers/gzdoom/pull/27

Okay, that was quite a bit more/less difficult than I expected.

Nash, can I show you how?

Guess anyone who's interested in using this will just have to wait. The rules didn't say forum code submissions are forbidden so unless that rule changes (or unless someone can help me do it [i]without installing additional software than I already have[/i])... ¯\(°_o)/¯

EDIT: can I just send a pull request for GZDoom then. The ZDoom changes can be backported easily, it's just adding 1 line in actor.h and thingdef_data.cpp. Super trivial stuff.

Oh my god, this feature would be awesome

I suggest SourceTree. I can teach you how to use that.