ZDoom

I suppose this can be closed as [Added] ...

[url=https://github.com/rheit/zdoom/pull/257]Done[/url].

Anyways, it seems as if all the pull requests were merged.

I assume the solution to this is the second one, so I'll make a new pull request which removes the 'perpetual' code.

But I asked some feedback in this thread....

[quote="Edward-san"]I'll wait for some feedback, then I can change the pull request to one or another branch accordingly.[/quote]

As a general rule, if you don't want to have a pull request merged, then *close it*!

Was this part of something else? I can't remember merging this.

Argh! Now you merged the first and wrong version...

Well, I committed two possible solutions to the issue:

[url=https://github.com/edward-san/zdoom/commit/b31b728cc41bc000dbfa2ed53c94c36f7ebec78b]Just add 'm_Dist == 0' check[/url];
[url=https://github.com/edward-san/zdoom/commit/ef8491c3345fe34b8bb5ced3ddd140971e0e41e7]Add 'm_Dist <= 0' and remove the perpetual code[/url].

I'll wait for some feedback, then I can change the pull request to one or another branch accordingly.

No idea, I just pointed out something that clearly was overlooked.

Mmm, indeed ... what about if I change the added condition to m_Dist == 0? Apparently this, too, fixes the issue.

[edit]Although, which wad uses a perpetual swinging polyobj door? Sounds weird to me...

		if (m_Dist <= 0 || poly->RotatePolyobj (m_Speed)) // <- disables rotation when m_Dist < 0
		{
			absSpeed = abs (m_Speed);
			if (m_Dist == -1)   <- ... so this means that perpetual polyobjs never rotate at all!
			{ // perpetual polyobj
				return;
			}
			m_Dist -= absSpeed;
			if (m_Dist <= 0)
			{
				SN_StopSequence (poly);
				if (!m_Close)
				{
					m_Dist = m_TotalDist;
					m_Close = true;
					m_Tics = m_WaitTics;
					m_Speed = -m_Speed;
				}
				else
				{
					Destroy ();
				}
			}

I don't think this is correct. Have a look:

[code]
if (m_Dist <= 0 || poly->RotatePolyobj (m_Speed)) // <- disables rotation when m_Dist < 0
{
absSpeed = abs (m_Speed);
if (m_Dist == -1) <- ... so this means that perpetual polyobjs never rotate at all!
{ // perpetual polyobj
return;
}
m_Dist -= absSpeed;
if (m_Dist <= 0)
{
SN_StopSequence (poly);
if (!m_Close)
{
m_Dist = m_TotalDist;
m_Close = true;
m_Tics = m_WaitTics;
m_Speed = -m_Speed;
}
else
{
Destroy ();
}
}
[/code]

[url=https://github.com/rheit/zdoom/pull/251]Pull request[/url].

I noticed this while testing the example wad for this zandronum [url=http://zandronum.com/tracker/view.php?id=2079]ticket[/url].

Load the harmless example wad: if a player blocks and tries to push the opened door, when the polyobj tried to close, it managed to rotate backwards wrongly, hence making the door pretty much bad.

It seems to work fine with the other example wads in the same ticket. I wonder why that code in [i]case PODOOR_SWING[/i] was a little bit different from [i]case PODOOR_SLIDE[/i] for all this time...