ZDoom

My bad. It's supposed to be the width it wraps text to. (Normally it wraps it to the width of the screen.) My only excuse is, as I said, I had to do quite a bit of work to the patch.

					if (WrapWidth != 0)
					{
						msg->SetWrapWidth(WrapWidth);
					}

	void SetWrapWidth(int wrap)
	{
		WrapWidth = wrap;
		ResetText(SourceText);
	}

	WrapWidth = 0;
	arc << WrapWidth;
	ClipX = ClipY = ClipWidth = ClipHeight = WrapWidth = 0;
	WrapWidth = wrap;
	int ClipX, ClipY, ClipWidth, ClipHeight, WrapWidth;	// in HUD coords

I was looking at the code trying to figure out if wrapwidth is a boolean meaning to wrap on the width; or an integer giving a width at which to wrap, and I don't understand how this works at all. It seems not to be actually referenced in code anywhere. It's assigned, and it's serialized, but I don't see any "SomeFunctionWhichUseWrapWidthAsParameter(WrapWidth)" call or "if (WrapWidth)". :?

I mean, except the obvious:
[code] if (WrapWidth != 0)
{
msg->SetWrapWidth(WrapWidth);
}
[/code]
[code] void SetWrapWidth(int wrap)
{
WrapWidth = wrap;
ResetText(SourceText);
}
[/code]

But that doesn't help since nothing else happens with it afterwards. It's not referenced in ResetText, for example; which instead uses HUDWidth and/or ClipWidth and/or SCREENWIDTH.

Searching for all references specifically to DHUDMessage::WrapWidth gives only these results:
[code]
WrapWidth = 0;
arc << WrapWidth;
ClipX = ClipY = ClipWidth = ClipHeight = WrapWidth = 0;
WrapWidth = wrap;
int ClipX, ClipY, ClipWidth, ClipHeight, WrapWidth; // in HUD coords
[/code]
assignation, serialization, assignation, assignation, definition. Never actual use.

[quote="randi"]I think this was a communication error due to English as a second language. It did wrap words; the only reason it didn't in that screenshot was because there were no space characters for line breaks, so it had to break at character boundaries instead.[/quote]
Oh! Well, that's perfect, then. :D

Kudos to all involved.

There was a surprising amount of work left to do to make this useable, but added for [rev]3960[/rev]. [size=85](Well, that commit message got formatted poorly. Oh well.)[/size]
[quote="Xaser"]its use for text is pretty limited because it doesn't wrap words.[/quote]
I think this was a communication error due to English as a second language. It did wrap words; the only reason it didn't in that screenshot was because there were no space characters for line breaks, so it had to break at character boundaries instead.

The strife-menu (dialogue, I mean) breaks between words properly doesn't it? It might not be reusable, but I think functions for breaking text into lines exists. Perhaps, with or without tweaking, it can be extended to provide breaking on words in hudmessages.

[quote="Jimmy"]How difficult would it be to add that? It's the only thing stopping this already quite useful feature from being "complete", and isn't it (I hate to use the "j-word") a case of telling the script where the space closest to the border of the cutoff box is, and wrapping the text at that point, instead of at whichever character crosses over the border?

I have no idea what I'm saying.[/quote]
I do.

How difficult would it be to add that? It's the only thing stopping this already quite useful feature from being "complete", and isn't it (I hate to use the "j-word") a case of telling the script where the space closest to the border of the cutoff box is, and wrapping the text at that point, instead of at whichever character crosses over the border?

I have no idea what I'm saying.

As nice as this will be for some things (say, a font of icons or somesuch), its use for text is pretty limited because it doesn't wrap words. Not that I'd oppose adding this, of course -- the "wrap" bool can be extended to a flags parameter later on that specifies the wrap type if someone's brave enough to code in word wrapping.

[quote]it wraps only symbols[/quote]
so if I get it correctly, it's not possible, right now, to distinguish between a letter and a space?

There's always a period of slow activity with ZDoom development because Randy is busy with other things... don't worry about it, if your submission is good and code is clean, it will be adapted eventually. :)

I wonder if this will be added to trunk, because i've already started to make a mod based on this feature.

No, it wraps only symbols, when they have reached the right border of the window

Ooh, that's sweet. :D Does it wrap individual words correctly as well (your screenshot only shows strings with underscores instead of proper spaces)?

I've made word wrap, patches are reuploaded

I don't think it was his intention to make text wrap within one of these windows, but I for one would definitely get some mileage out of such a feature.