HITSELF flag for projectiles

Post a reply

Smilies
:D :) :( :o :shock: :? 8-) :lol: :x :P :oops: :cry: :evil: :twisted: :roll: :wink: :geek: :ugeek: :!: :?: :idea: :arrow: :| :mrgreen: :3: :wub: >:( :blergh:
View more smilies

BBCode is OFF
Smilies are ON

Topic review
   

Expand view Topic review: HITSELF flag for projectiles

Re: HITSELF flag for projectiles

by Graf Zahl » Sat Jun 09, 2012 2:45 am

What I said before. If you just dump an incomplete feature in here and don't respond to feedback I see no reason to add it.

Re: HITSELF flag for projectiles

by Graf Zahl » Sat Apr 07, 2012 7:27 am

As it is I won't add it. There's some issues here:

1. Why only players? That restriction makes no sense.
2. Any new actor variable involved needs to be saved in savegames or there'll be some problems,

Re: HITSELF flag for projectiles

by Edward-san » Fri Jul 29, 2011 2:44 pm

Yes.

Re: HITSELF flag for projectiles

by kgsws-CZ » Fri Jul 29, 2011 1:46 pm

What should i use to create patches now? Just "svn diff > something.txt"?

Re: HITSELF flag for projectiles

by Edward-san » Fri Jul 29, 2011 1:49 am

kgsws, let me say this: don't use "diff -rup".
I tried to apply the patch in the src directory with this command:
"patch -Np2 -i ../hitself.diff -F5 --ignore-whitespace"
and the result was:

Code: Select all

patching file actor.h
Hunk #1 succeeded at 330 with fuzz 3.
Hunk #2 succeeded at 817 with fuzz 3.
patching file p_map.cpp
Hunk #1 FAILED at 1024.
1 out of 1 hunk FAILED -- saving rejects to file p_map.cpp.rej
patching file p_mobj.cpp
Hunk #1 succeeded at 5303 with fuzz 3.
patching file thingdef/thingdef_data.cpp
Hunk #1 succeeded at 233 with fuzz 3.
Now I re-created the patch ("svn diff > canhitshooter.txt" ) with the following changes:
- Change the name HITSELF to CANHITSHOOTER;
- Moved the "return" attached to the "if( )" in p_map.cpp in a new line for a better readability.

The compiling is fine, so here it is.
canhitshooter.txt
(2.67 KiB) Downloaded 48 times

Re: HITSELF flag for projectiles

by kgsws-CZ » Thu Jul 28, 2011 4:53 am

Feel free to change name :)

Re: HITSELF flag for projectiles

by Enjay » Wed Jul 27, 2011 10:28 am

Or even +CANHITSHOOTER to indicate that it can do it but isn't compelled to. ;)

(ie It wouldn't turn around and try to target the shooter simply because it had the flag.)

Re: HITSELF flag for projectiles

by NeuralStunner » Wed Jul 27, 2011 9:46 am

Wouldn't HITSHOOTER be a more intuitive name? (Seeing as my first thought, upon seeing the title, was "why would you want a projectile to hit itself?" :lol: )

HITSELF flag for projectiles

by kgsws-CZ » Wed Jul 27, 2011 3:12 am

This flag will allow projectiles to hit even shooter (player only). Projectile becomes lethal once you stop touching it for first time.
Attachments
hitself.zip
(2.87 KiB) Downloaded 44 times

Top