ZDoom

Fixed. Please redownload.

Oh, right. Erm, damn, let me fix up mine, it's all up to date at this point.

The patch doesn't work anymore. Too many changes since it was posted.

Sorry for the bump but I figured I'd just say that this feature is finished and ready to go.

Okay, I think the last crashing obstacle has been flattened out.

It didn't have the NULL pointer checks for Thing_Destroy when I used it, but I fixed it for you. It's in the first post now.

Fixed patch.

Found another bug: Receiving damage from damaging floors (i.e. slime pits, lava, etc.) causes the game to crash. I've gotten that sucker pinpointed, now to fix it...

Fixed it. Please redownload.

I had to ensure that at least it wasn't just me first.

The one about Thing_Destroy()? Yeah, I got it, but no, I haven't looked into it. You didn't tell me any useful info (like, does it happen with that patch or without). If it happens only with the patch, then why did you went ahead and suggested it as-is? If it happens also without, why didn't you make a bug report thread?

Anyway, presumably, all it's missing is a NULL pointer check.

AEoD has countless numbers of monsters with coupled death states, for example... That's just a bloody nightmare.

Speaking of, Gez, you got my PM, right?

Gez wrote:The idea is that you can decouple damage factors, pain anim and death anims.

Ah, right. Now, that makes sense. Thanks.

The idea is that you can decouple damage factors, pain anim and death anims.

When you start using pain states for various effects, have a variety of death animations for various means of death, and use plenty of damage factors to control monsters' friendly fire and the likes, you can obtain silly things as a result. With the proliferation of combinations, you increase the likelihood that you'll forget to give a damage factor to one monster or something like that.

With these things, instead of having DamageType that governs both DamageFactor, PainState and DeathState, you have DamageType <--> DamageFactor, PainType <--> PainState, and DeathType <--> DeathState. (Of course, for backward compatibility reasons, DamageType is still the fallback if the latter two aren't defined.)

Forgive me for being thick here but I don't see the advantage.

Perhaps I'm just not understanding this properly but, for example, the example you gave (bad sentence ) may be simpler but surely it would require entries of similar size to the saving in that one actor to be placed elsewhere (eg the projectile actor?). I'm not sure how to use this to actually save anything or do anything desperately different from before.

I'm not trying to be awkward. I'm sure there must be an advantage somewhere but I'm just not seeing it ATM.