[r3008] 1600x900 video mode doesn't use the whole window

Forum rules
Please don't bump threads here if you have a problem - it will often be forgotten about if you do. Instead, make a new thread here.

Post a reply

Smilies
:D :) :( :o :shock: :? 8-) :lol: :x :P :oops: :cry: :evil: :twisted: :roll: :wink: :geek: :ugeek: :!: :?: :idea: :arrow: :| :mrgreen: :3: :wub: >:( :blergh:
View more smilies
BBCode is OFF
Smilies are ON
Topic review
   

Expand view Topic review: [r3008] 1600x900 video mode doesn't use the whole window

Re: [r3008] 1600x900 video mode doesn't use the whole window

by randi » Mon Jun 20, 2011 4:09 pm

Well, this was the fix. Can you figure it out from that?

Re: [r3008] 1600x900 video mode doesn't use the whole window

by Bio Hazard » Mon Jun 20, 2011 1:46 pm

Now I'm all curious what exactly the specific conditions and effects were...

Re: [r3008] 1600x900 video mode doesn't use the whole window

by Janizdreg » Sat Jun 18, 2011 9:49 pm

Awesome, thanks so much for fixing this! This particular fix improves my ZDoom experience a great deal. =)

Re: [r3008] 1600x900 video mode doesn't use the whole window

by randi » Sat Jun 18, 2011 10:54 am

Well, if you must: Specific conditions that can only be fulfilled on some computers but not others.

Re: [r3008] 1600x900 video mode doesn't use the whole window

by NeuralStunner » Sat Jun 18, 2011 10:49 am

Xtyfe wrote:Don't all bugs usually require specific circumstances to show up :P
I guess you could say that, though some are no more specific than "the program runs". :P

Re: [r3008] 1600x900 video mode doesn't use the whole window

by Xtyfe » Sat Jun 18, 2011 10:09 am

randy wrote:Thanks for the help.

To anyone wondering: This is not a driver bug. It was a ZDoom bug that required specific circumstances to show up.
Don't all bugs usually require specific circumstances to show up :P

Re: [r3008] 1600x900 video mode doesn't use the whole window

by randi » Fri Jun 17, 2011 11:20 pm

Thanks for the help.

To anyone wondering: This is not a driver bug. It was a ZDoom bug that required specific circumstances to show up.

Re: [r3008] 1600x900 video mode doesn't use the whole window

by Zhs2 » Thu Jun 16, 2011 11:20 pm

Wow, no black bar in software at 1600x900. I'm glad I was able to be of assistance. The numbers were 1600 1644 1644.

Also, weird. I've grabbed the distribution of VC++ 2005 from the [wiki=Compile_ZDoom_on_Windows]appropriate wiki page[/wiki], gonna get that set up so I can debug this and possibly tie up any loose ends.

Edit: No such luck with VC++ 2005... I'll try back a bit later after I've gotten some sleep with something newer.

Re: [r3008] 1600x900 video mode doesn't use the whole window

by randi » Thu Jun 16, 2011 10:13 pm

If you install Visual C++, you'll get the debugger with it. I'm afraid those errors aren't useful without breaking into a debugger at that point, since they're in generic functions that are called by every ctype function, including a locale-aware version. (I didn't think I used any locale-aware ctype functions?)

Anyway, I realized I was actually changing three separate things rather than just one with that binary, so here's a different one. It also prints some numbers if you would be so kind as to report what they are.
Attachments
zdoom.7z
(1.11 MiB) Downloaded 39 times

Re: [r3008] 1600x900 video mode doesn't use the whole window

by Zhs2 » Thu Jun 16, 2011 7:52 pm

Image

(Also, I'm not sure if I have a debugger worth using (not sure if I'd do much good with whatever MinGW provides,) but the steps on how to get one would be nice indeed, seeing as Visual C++ seems to be the standard here)

Re: [r3008] 1600x900 video mode doesn't use the whole window

by randi » Thu Jun 16, 2011 5:51 pm

Interesting. What was the specific text of the assertions? It might be related. (If you had a debugger, it would be nice to know what part of zdoom these ctype calls came from, too.)

Re: [r3008] 1600x900 video mode doesn't use the whole window

by Zhs2 » Thu Jun 16, 2011 4:22 pm

Spoiler: :D
Also, not sure if it matters, but a couple of debug assertion failures popped up on execution, although Ignore allowed me to see what I needed to. For reference, they were on lines 56 and 68 in isctype.c. :P

Re: [r3008] 1600x900 video mode doesn't use the whole window

by randi » Wed Jun 15, 2011 10:16 pm

So far this looks like a system-specific problem which I might be able to work around.

So, how does this executable fare? It does not try to be a fix. I want to see if I can draw to the bottom of the screen if I only update a portion of the texture. So this only draws the left half of your screen. But if we're lucky, it will be the full height.
Attachments
zdoomd.7z
(1.26 MiB) Downloaded 35 times

Re: [r3008] 1600x900 video mode doesn't use the whole window

by Zhs2 » Mon Jun 13, 2011 10:19 pm

Screen melts do not seem to be affected by the black bar problem; in fact, the black bar is included in the melt animation. Seems to only be a problem with rendering the game itself (it's not present on the titlepic either.)

I wish I could test heights above 900, but oh well. Going to try some smaller resolution heights and see if they have the same problem.

Edit: Yes, they do. I went all the way to 1600x400, but 1600x300 caused ZDoom to crash for likely very obvious reasons. Screenshot evidence can be found in the same location.

Re: [r3008] 1600x900 video mode doesn't use the whole window

by randi » Mon Jun 13, 2011 10:07 pm

Weird. Are all resolutions with a width of 1600 affected?

Also, how do screen melts fare? Do they also have the black band where they don't draw?

Top