[r2819/r974] KEYCONF & LANGUAGE bugs

Forum rules
Please don't bump threads here if you have a problem - it will often be forgotten about if you do. Instead, make a new thread here.

Post a reply

Smilies
:D :) :( :o :shock: :? 8-) :lol: :x :P :oops: :cry: :evil: :twisted: :roll: :wink: :geek: :ugeek: :!: :?: :idea: :arrow: :| :mrgreen: :3: :wub: >:( :blergh:
View more smilies
BBCode is OFF
Smilies are ON
Topic review
   

Expand view Topic review: [r2819/r974] KEYCONF & LANGUAGE bugs

Re: [r2819/r974] KEYCONF & LANGUAGE bugs

by Graf Zahl » Tue Sep 21, 2010 10:50 am

The player class display is fixed in r2841.

Re: [r2819/r974] KEYCONF & LANGUAGE bugs

by Graf Zahl » Tue Sep 21, 2010 10:42 am

38 is ok for the generic skill names. I already addressed this problem in r2840 by automatically centering the options.

Re: [r2819/r974] KEYCONF & LANGUAGE bugs

by The Ultimate DooMer » Tue Sep 21, 2010 9:04 am

Finally, one more little menu-related thing...the default x-position of the Hexen skill settings is too far left:

Code: Select all

ListMenu "SkillMenu"
{

	IfGame(Doom, Chex)
	{
		StaticPatch 96, 14, "M_NEWG"
	}
	IfGame(Strife)
	{
		StaticPatch 96, 14, "M_NGAME"
	}
	IfGame(Doom, Strife, Chex)
	{
		StaticPatch 54, 38, "M_SKILL"
		Position 48, 63
	}
	IfGame (Heretic)
	{
		Position 38, 30
	}
	IfGame (Hexen)
	{
		StaticText 74, 16, "$MNU_CHOOSESKILL"
		Position 38, 44
	}
}
I recommend changing it from 38 to 120, that's pretty much the original position.

Re: [r2819/r974] KEYCONF & LANGUAGE bugs

by Graf Zahl » Tue Sep 21, 2010 8:49 am

Crap. I think I know what causes this. ZDoom's texture system with its shitload of texture types is acting up again.

Re: [r2819/r974] KEYCONF & LANGUAGE bugs

by The Ultimate DooMer » Tue Sep 21, 2010 8:22 am

That's the subfolder they were in.

Re: [r2819/r974] KEYCONF & LANGUAGE bugs

by Graf Zahl » Tue Sep 21, 2010 8:16 am

They should be in the Graphics/ folder.

Re: [r2819/r974] KEYCONF & LANGUAGE bugs

by The Ultimate DooMer » Tue Sep 21, 2010 7:50 am

I have it now - in my project, the graphics are in a subfolder inside the pk3...copying them to the root folder (as in the test wad) made them work as normal.

Re: [r2819/r974] KEYCONF & LANGUAGE bugs

by Graf Zahl » Tue Sep 21, 2010 7:15 am

No problems with that. I get your replaced animation for the Cleric. It's all as it should be.

Re: [r2819/r974] KEYCONF & LANGUAGE bugs

by The Ultimate DooMer » Tue Sep 21, 2010 6:58 am

That one had no replacement graphics, here's a new one.

(I've added the portrait boxes too, as they're not being overridden by my replacements either)
Attachments
menutest2.zip
(24.35 KiB) Downloaded 66 times

Re: [r2819/r974] KEYCONF & LANGUAGE bugs

by Graf Zahl » Tue Sep 21, 2010 6:32 am

Hm, that's odd. When I load your test WAD and add the new display names to the redefinitions I get the portraits in the menu as before.

Re: [r2819/r974] KEYCONF & LANGUAGE bugs

by The Ultimate DooMer » Tue Sep 21, 2010 5:30 am

They inherit and replace Fighter/Cleric/MagePlayer. I tried adding the portrait property and I got the plain green box instead of the Hexen one, with the portrait also animating faster. Trying the box instead just gave me the box with no portrait inside.

Re: [r2819/r974] KEYCONF & LANGUAGE bugs

by Graf Zahl » Tue Sep 21, 2010 4:51 am

The Ultimate DooMer wrote:I've just noticed it's ignoring my M_CWALK1-4 replacements (the animated player display inside the box), and the box disappears altogether when the mouse cursor is not on any of the class names.
Do your player classes inherit from the original Hexen players? If not, you may have to copy the 'player.portrait' property which is now being used for these animations.

The second part is normal. If no player is selected, none can be shown, right?

Re: [r2819/r974] KEYCONF & LANGUAGE bugs

by The Ultimate DooMer » Tue Sep 21, 2010 4:08 am

No problem, I added a Player.DisplayName to each class and it's fine now. A couple of other minor things: I've just noticed it's ignoring my M_CWALK1-4 replacements (the animated player display inside the box), and the box disappears altogether when the mouse cursor is not on any of the class names.

(the wiki for the new menu stuff isn't complete yet so I don't know what's meant to work now or how to recreate the menu with the new code)

Re: [r2819/r974] KEYCONF & LANGUAGE bugs

by Graf Zahl » Tue Sep 21, 2010 12:16 am

The reason for that is that the language string is no longer used. I merged Hexen's special playerclass menu with the generic one but that uses the players' displaynames.

However, and here lies the problem, Grubber used the 'display'names for purposes other than just displaying them so I have 2 choices now: Either risk breaking a handful of mods or leave it as it is which means that player class displaynames cannot be stringtable references.

Re: [r2819/r974] KEYCONF & LANGUAGE bugs

by The Ultimate DooMer » Mon Sep 20, 2010 6:46 pm

It's still ignoring my LANGUAGE lump for player class strings, that's only a minor bug though.

Top