ZDoom

Maybe so, but not by much, and in the case of a heavily-loaded table, I suspect it may even be more efficient to have it in there than to leave it out.

Except that it's less efficient.

[quote="Graf Zahl"]Leave 1.0 entries in the damage factors table[/quote]
I can't see anything wrong with just doing that.

[quote="Graf Zahl"]1.0001 should also work. To fix this I have 2 choices: Leave 1.0 entries in the damage factors table or clean the table in actor postprocessing off all unnecessary entries.[/quote]
If you go looking around in that code, hopefully you can find out [url=http://forum.zdoom.org/viewtopic.php?f=2&t=25403&p=485278#p485278]where this problem is coming from[/url].

Yeah, I tested it yesterday and it worked just great. Thanks guys.

1.0001 should also work. To fix this I have 2 choices: Leave 1.0 entries in the damage factors table or clean the table in actor postprocessing off all unnecessary entries.

[quote="Graf Zahl"]The problem here is actually that damage factors of 1.0 are not put into the damage factors list because it's the default. Obviously that's not a good idea when there's a setting for 'normal' damage in there as well.[/quote]

So, putting "damagefactor "Weakness", 1.2" should do the trick?

So what do you recommend we use to fix this?

The problem here is actually that damage factors of 1.0 are not put into the damage factors list because it's the default. Obviously that's not a good idea when there's a setting for 'normal' damage in there as well.

I understood all that. I was testing the possibility that "Normal" was adjusting [i]all[/i] incoming damage beforehand. I obviously found that was not the case. (Sorry for my wording implying that I was assuming that behavior.) I [i]did[/i] find that it was something else entirely...

BTW, I've found no recent changes to DamageFactor handling in the changelog, either.

[quote="NeuralStunner"]More testing done. I tried the following lines:[code]
DamageFactor "Normal", 0.01
DamageFactor "Bullet", 100
[/code]
So, setting "Bullet" damage to 100 should more or less counteract the 1% from "Normal", right? No, actually hitting the Imp with a single bullet results in an instagib.[/quote]
No, it should not counteract.

You first are telling the game that all damage will be considered x0.01
[u]Then[/u] you're telling the game that bullet damage will be multiplied by 100. Right there you're saying that the game will consider 2 types of damage [b]separately[/b]: "normal" and "bullet". So, "normal" (all damage except "bullet") will deal x0.01. Bullet (not considered [i]inside[/i] "normal") will deal x100
Resume: all damage, except "bullet" will deal x0.01; and "bullet" will be dealt x100

[quote="NeuralStunner"]
This had the [i]same result[/i]:[code]
DamageFactor "Normal", 0.0
DamageFactor "Bullet", 100
[/code][/quote]
Exact same case
Telling the game that all damage will be ignored ("normal" 0.0)
then that bulled will be dealt x100.
All damage but "Bullet" will be ignored. "Bullet" will be dealt x100


[quote="NeuralStunner"]But! This works as expected:[code]
DamageFactor "Normal", 0.0
DamageFactor "Bullet", 1.0001
[/code][/quote]
Then, you're telling the game that all damage ("all damage" = "normal" = all unespecified damage) will be ignored and that bullet will deal 0.0001 more than the regular damage it would deal regularly (not counting at all the previous "damagefactor "normal", 0.0).

If you put "normal" you're talking about all damage, then if you specify another damage, it's considered separately and overrides the damage factor applied by "normal"

So, another way to say it, both damage calculations are being done parallel, instead of being done consecutively.

Check this
[spoiler][quote="DBThanatos"]Anyway, one monster, should be immune to everything except one type of custom damage. I have made large tests and I have succesfully reduced all possible damage in Zdoom to 0, that is:

[code] DamageFactor "normal" , 0.0 //any non custom damage
DamageFactor "Fire" , 0.0 //lots of hexen projectiles
DamageFactor "Ice" , 0.0 //more hexen projectiles
DamageFactor "Electric" , 0.0 //I believe is the arc of death. This one was mentioned in the maulotaur's code
DamageFactor "Explosion" , 0.0 //Not sure, please correct me if Im wrong or if it doesnt exist
DamageFactor "Disintegrate", 0.0 //strife
DamageFactor "Extreme", 0.0 //I believe that's how is called please correct me if wrong
DamageFactor "Poison", 0.0 //hexen
DamageFactor "Railgun", 0.0 //I didnt know why my railgun was killing the mosnter, so i tried this and worked :D
DamageFactor "Melee", 0.0 //I didnt know it was considered apart, but it is
DamageFactor "BFGSplash", 0.0 //self explanatory[/code]

And I think those are all. Except that the "HolyMissile" (from the cleric's wraith verge, the main shot which fires the 4 ghosts) is still killing it. I checked the decorate of it, and it doesnt seems to have any custom damage type, at least not visible; I assume it is hardcoded or something. Anyone knows how is called or how to cancel it?
[/quote]

[quote="Graf Zahl"]After seeing this thread I realized that there's a serious bug in the damage type system. [u]DamageFactor "Normal" is supposed to protect against all types of damage that don't have a specific factor assigned[/u]. Otherwise it will never properly work.

So in your case, the proper method would have been to specify

DamageFactors "Normal", 0
DamageFactors "AllowedDamageTypeForThisMonster", 1.0 or whatever
[/quote][/spoiler]

That is, how it's [i]supposed[/i] to work. For some reason the explicit 1.0 setting doesn't seem to be overriding the 0.0 any more.

Yeah, but still, this was working just fine until recently... *scratches back of head*

Looking back at the actor properties, I do see we can attempt "DamageFactor 0.0", albeit when I tried to add DamageFactor "Weakness", 1.0 it seemed to have overwritten the first one...

Well, [url=http://forum.zdoom.org/viewtopic.php?f=3&t=20719]this topic[/url] (especifically [url=http://forum.zdoom.org/viewtopic.php?f=3&t=20719#p406374]this post[/url]) helps a lot understanding how the damage types works for "normal" and others.

...OH! Thanks mate.

Anyway, Graf, could you look into this?