[since 2.2.0] Voodoo doll gets stuck

Forum rules
Please don't bump threads here if you have a problem - it will often be forgotten about if you do. Instead, make a new thread here.

Post a reply

Smilies
:D :) :( :o :shock: :? 8-) :lol: :x :P :oops: :cry: :evil: :twisted: :roll: :wink: :geek: :ugeek: :!: :?: :idea: :arrow: :| :mrgreen: :3: :wub: >:( :blergh:
View more smilies

BBCode is OFF
Smilies are ON

Topic review
   

Expand view Topic review: [since 2.2.0] Voodoo doll gets stuck

Re: [since 2.2.0] Voodoo doll gets stuck

by Xtroose » Thu Feb 11, 2010 11:21 am

Thank you.

Re: [since 2.2.0] Voodoo doll gets stuck

by Graf Zahl » Thu Feb 11, 2010 11:10 am

Yup, r555 it was. Fixed.

Re: [since 2.2.0] Voodoo doll gets stuck

by Graf Zahl » Thu Feb 11, 2010 11:02 am

Well, having some GZDoom releases hanging around, I was able to narrow the change down to r553 to r563.

In 1.0.27 (based on ZDoom r553) it was still working but in 1.0.28 (r563) it was not.


My bet is r555 which did make a change to the sliding code.

Re: [since 2.2.0] Voodoo doll gets stuck

by Gez » Thu Feb 11, 2010 10:11 am

Deathlike2 wrote:It may be a good idea to look into what revision is causing it (unless SVN was moved post 2.2.0). It would be a good idea to look into commits mentioning Voodoo dolls and/or fixes related to that.
2.1.7 was r366. 2.2.0 was r747. So I guess the first revision to rest would be r557. Then let's say it works there too, you'd look at r652. And so on, cutting in the middle each time. This way, you have at most eight or nine revisions to test.

That's more reliable than just looking at revisions that mention voodoo dolls because:
1. It might be caused by an unrelated change
2. Sometimes a revision log doesn't actually tell everything it changed; to give a recent example, this did more than just add code I made. It also changed things in p_setup.cpp, for instance.

Re: [since 2.2.0] Voodoo doll gets stuck

by Deathlike2 » Thu Feb 11, 2010 9:53 am

It may be a good idea to look into what revision is causing it (unless SVN was moved post 2.2.0). It would be a good idea to look into commits mentioning Voodoo dolls and/or fixes related to that.

Re: [since 2.2.0] Voodoo doll gets stuck

by Xtroose » Thu Feb 11, 2010 7:10 am

They did not fix anything, it behaves exactly like in ZDoom. Confirmed with the latest build 2665 (98b branch), released on February 7, 2010.

Re: [since 2.2.0] Voodoo doll gets stuck

by Graf Zahl » Thu Feb 11, 2010 1:46 am

I have access but I have no idea which of their changes (if it even exists) might be responsible.

Re: [since 2.2.0] Voodoo doll gets stuck

by Gez » Wed Feb 10, 2010 11:40 pm

Why? Their codebase is too different, or you no longer have access to their SVN?

Re: [since 2.2.0] Voodoo doll gets stuck

by randi » Wed Feb 10, 2010 5:59 pm

I can't backport anything from Skulltag.

Re: [since 2.2.0] Voodoo doll gets stuck

by Recurracy » Wed Feb 10, 2010 5:52 am

AFAIK it has been fixed in skulltag, Randy might want to backport it.

[since 2.2.0] Voodoo doll gets stuck

by Xtroose » Wed Feb 10, 2010 5:48 am

In ZDoom compatible source ports the voodoo doll gets stuck. If you damage the voodoo doll, it will start moving and will continue moving as expected. In Boom 2.02 the voodoo doll does not get stuck.

This used to work in ZDoom, but is now broken. The last official version in which it works as expected is ZDoom 2.1.7. In 2.2.0 and later it is broken.

I have made a test level to reproduce this behavior. Download

Top