Welcome to the ZDoom Forums!

Odd, [url=http://zdoom.org/svndiff/1682/zdoom/trunk/src/info.cpp]what happened to the newlines[/url]? It's not important anyway.

[quote="ThatOneZDoomer"]I thought to myself "I hope I don't make the mistake of getting the skill and decorate actor defining mixed up" and with just this example alone, I already made that mistake :| . Well, I'm sure the wiki page will make it clear that skill replacements are applied before decorate replacements to avoid threads asking why they couldn't get the feature to work correctly.[/quote]
[url=http://zdoom.org/wiki/MAPINFO/Skill_definition]You tell me.[/url]

I thought to myself "I hope I don't make the mistake of getting the skill and decorate actor defining mixed up" and with just this example alone, I already made that mistake :| . Well, I'm sure the wiki page will make it clear that skill replacements are applied before decorate replacements to avoid threads asking why they couldn't get the feature to work correctly.

skill leet
{
   spawnfilter = 4
   name = "No n00bs allowed!!"
   ReplaceActor = "DoomImp", "ImpSpawnerHard"
}

Skill replacements are applied before DECORATE replacement, so in your example what you'll want is this:

[code]skill leet
{
spawnfilter = 4
name = "No n00bs allowed!!"
ReplaceActor = "DoomImp", "ImpSpawnerHard"
}[/code]

Actor ImpSpawner : RandomSpawner replaces DoomImp
{
   DropItem "WimpyImp"
   DropItem "RedShirtImp"
}

Actor ImpSpawnerHard : RandomSpawner
{
   DropItem "UberImp"
   DropItem "1337Imp"
}

skill leet
{
   spawnfilter = 4
   name = "No n00bs allowed!!"
   ReplaceActor = "ImpSpawner", "ImpSpawnerHard"
}

skill leet
{
   spawnfilter = 4
   name = "No n00bs allowed!!"
   ReplaceActor = "WimpyImp", "UberImp"
   ReplaceActor = "RedShirtImp", "1337Imp"
}

Finally, it's here, a non-hacky way of changing actors based on skill level! No more buggy way of doing it with A_SpawnThingEx that breaks scripts. I know I'll be using this for sure. Just a quick question...

Will this work in combination with your Random Spawner while still keeping scripts functional? In a way, it'll be like a double replacement or something like that. Something like this...

[code]Actor ImpSpawner : RandomSpawner replaces DoomImp
{
DropItem "WimpyImp"
DropItem "RedShirtImp"
}

Actor ImpSpawnerHard : RandomSpawner
{
DropItem "UberImp"
DropItem "1337Imp"
}[/code]

[code]skill leet
{
spawnfilter = 4
name = "No n00bs allowed!!"
ReplaceActor = "ImpSpawner", "ImpSpawnerHard"
}[/code]

Or would I have to do it this way, if it works at all?

[code]skill leet
{
spawnfilter = 4
name = "No n00bs allowed!!"
ReplaceActor = "WimpyImp", "UberImp"
ReplaceActor = "RedShirtImp", "1337Imp"
}[/code]

What, already? Damn that was fast. I revised it to handle erroneous actor definitions more gracefully.

i like :D

skill test
{
	spawnfilter = 4
	name = "Massive upgrade!"
	ReplaceActor = "ZombieMan", "ShotgunGuy"
	ReplaceActor = "ShotgunGuy", "ChaingunGuy"
	ReplaceActor = "Demon", "Spectre"
	ReplaceActor = "Fatso", "BaronOfHell"
	ammofactor = 2
	dropammofactor = 1
}

Actor Imp : DoomImp replaces ChaingunGuy {}
Actor FirstAid : Medikit replaces ShotgunGuy {}

As discussed in the [url=http://forum.zdoom.org/viewtopic.php?f=15&t=18446&start=15]Additions to skill definition[/url] thread. This patch adds a new skill property to skill definitions: ReplaceActor.

Example of use:
[code]skill test
{
spawnfilter = 4
name = "Massive upgrade!"
ReplaceActor = "ZombieMan", "ShotgunGuy"
ReplaceActor = "ShotgunGuy", "ChaingunGuy"
ReplaceActor = "Demon", "Spectre"
ReplaceActor = "Fatso", "BaronOfHell"
ammofactor = 2
dropammofactor = 1
}[/code]
Skill-based replacements are not transitive: zombies are replaced by sergeants, and sergeants by commandos, but zombies aren't replaced by commandos.

The implementation has the skill replacements applied first, followed by any DECORATE replacement. For example, if the above MAPINFO code is combined with this DECORATE code...
[code]Actor Imp : DoomImp replaces ChaingunGuy {}
Actor FirstAid : Medikit replaces ShotgunGuy {}[/code]
... then in the level the sergeants will be replaced by imps, not with medikits. But the former humans will end up being replaced by medikits.

This implementation only changes the FActorInfo::GetReplacement and GetReplacee functions, instead of altering many other functions. As such it is I think the cleanest it can be.