Hexen: LFEDGE/RTEDGE drawn too high

Forum rules
Please don't bump threads here if you have a problem - it will often be forgotten about if you do. Instead, make a new thread here.

Post a reply

Smilies
:D :) :( :o :shock: :? 8-) :lol: :x :P :oops: :cry: :evil: :twisted: :roll: :wink: :geek: :ugeek: :!: :?: :idea: :arrow: :| :mrgreen: :3: :wub: >:( :blergh:
View more smilies

BBCode is OFF
Smilies are ON

Topic review
   

Expand view Topic review: Hexen: LFEDGE/RTEDGE drawn too high

Re: Hexen: LFEDGE/RTEDGE drawn too high

by Rachael » Wed Jun 02, 2021 2:54 pm

After a tedious and frustrating fight with my local git repo where I was creating a custom build for somebody, I've come to the conclusion that I fully support your decision to abandon submodules completely. They are ... to put it EXTREMELY nicely, ... a fucking nightmare, and the worst implementation of a feature I have ever experienced.

Re: Hexen: LFEDGE/RTEDGE drawn too high

by Graf Zahl » Thu May 27, 2021 7:29 am

They are really nice on paper, and work fine most of the time if you just commit, push and pull - but don't change the linked repo's content, but constantly cause problems if you need to switch between branches, or bisect the repo to track down an error. Half the time they don't update properly, sometime they even completely lose track of the actual commit etc. The trouble started for me the last time I had to reset the repo to an older state to find the cause of a bug. I guess if I freshly checked out again it'll work again, but for how long?

In all honesty, I never trusted them to begin with, but did it this time because I didn't want to get all the binary baggage into our own commit tree.

Re: Hexen: LFEDGE/RTEDGE drawn too high

by Rachael » Thu May 27, 2021 7:15 am

Glad we figured that out before converting all the libraries over to submodules. That could have ended badly.

Re: Hexen: LFEDGE/RTEDGE drawn too high

by Graf Zahl » Thu May 27, 2021 5:59 am

I'm still having issues with the submodule. It just won't update and I get no help from Git why.
So this will go away ASAP once Nash has completed his work.
It was the first and the last time to ever bother with them.
At work we have a colleague who loves to use them and in recent weeks converted half of our repos to using submodules, and as a result projects now constantly break, so fuck 'em!

Git really needs something better to link child repos without dragging in their entire content.

Re: Hexen: LFEDGE/RTEDGE drawn too high

by Rachael » Sat May 22, 2021 3:34 am

Yeah Git has really user-unfriendly handling of submodules which is why some people are understandably averse to them. They are great if you know how they work and exactly what to do at exactly what point but the documentation on them really isn't great and it seems like it is way easier than it should be to actually screw things up. In fact I was worried that even having the update inside of a pull request would cause problems, but it does seem like the merge went smoothly.

I will still eventually try to migrate the internal libraries to submodules (at least the ones we didn't change), but today's confusion only foreshadows what will be bigger issues later on with them, I think.

Re: Hexen: LFEDGE/RTEDGE drawn too high

by Graf Zahl » Fri May 21, 2021 4:02 pm

Git stubbornly tells me it's up to date but the files simply are not there.I had to manually reset the branch to finally get them...

Re: Hexen: LFEDGE/RTEDGE drawn too high

by Rachael » Fri May 21, 2021 3:38 pm

I just did a fresh checkout and then created an archive from it using the following commands:

Code: Select all

C:\Projects\gzdoom2>git submodule init
Submodule 'wadsrc_widescreen/static' (https://github.com/nashmuhandes/WidePix) registered for path 'wadsrc_widescreen/static'

C:\Projects\gzdoom2>git pull --recurse-submodules
Already up to date.
Cloning into 'C:/Projects/gzdoom2/wadsrc_widescreen/static'...
Submodule path 'wadsrc_widescreen/static': checked out 'd458411db4795dfd1420cf1c6456f6d2999b3bad'

C:\Projects\gzdoom2\wadsrc_widescreen\static>zip -r9 /users/Rachael/game_widescreen_gfx.pk3 .
updating: filter/doom.id.doom1.registered/graphics/titlepic.lmp (172 bytes security) (deflated 51%)
updating: filter/doom.id.doom1.shareware/graphics/titlepic.lmp (172 bytes security) (deflated 53%)
updating: filter/doom.id.doom1.ultimate/graphics/credit.lmp (172 bytes security) (deflated 48%)
updating: filter/doom.id.doom1.ultimate/graphics/titlepic.lmp (172 bytes security) (deflated 51%)
updating: filter/doom.id.doom1.ultimate/textures.txt (172 bytes security) (deflated 8%)
updating: filter/doom.id.doom1/graphics/credit.lmp (172 bytes security) (deflated 63%)
updating: filter/doom.id.doom1/graphics/help1.lmp (172 bytes security) (deflated 71%)
updating: filter/doom.id.doom1/graphics/help2.lmp (172 bytes security) (deflated 64%)
updating: filter/doom.id.doom2.plutonia/graphics/titlepic.lmp (172 bytes security) (deflated 48%)
updating: filter/doom.id.doom2.plutonia/textures.txt (172 bytes security) (deflated 39%)
updating: filter/doom.id.doom2.tnt/graphics/titlepic.lmp (172 bytes security) (deflated 66%)
updating: filter/doom.id.doom2.tnt/textures.txt (172 bytes security) (deflated 39%)
updating: filter/doom.id.doom2/graphics/credit.lmp (172 bytes security) (deflated 61%)
updating: filter/doom.id.doom2/graphics/help.lmp (172 bytes security) (deflated 67%)
updating: filter/doom.id.doom2/graphics/titlepic.lmp (172 bytes security) (deflated 57%)
updating: filter/doom.id/graphics/bossback.lmp (172 bytes security) (deflated 64%)
updating: filter/doom.id/graphics/credit.lmp (172 bytes security) (deflated 61%)
updating: filter/doom.id/graphics/endpic.lmp (172 bytes security) (deflated 63%)
updating: filter/doom.id/graphics/help.lmp (172 bytes security) (deflated 67%)
updating: filter/doom.id/graphics/inter_e4.lmp (172 bytes security) (deflated 62%)
updating: filter/doom.id/graphics/interpic.lmp (172 bytes security) (deflated 58%)
updating: filter/doom.id/graphics/pfub1.lmp (172 bytes security) (deflated 70%)
updating: filter/doom.id/graphics/pfub2.lmp (172 bytes security) (deflated 65%)
updating: filter/doom.id/graphics/pluboss.lmp (172 bytes security) (deflated 68%)
updating: filter/doom.id/graphics/pluinter.lmp (172 bytes security) (deflated 66%)
updating: filter/doom.id/graphics/tntboss.lmp (172 bytes security) (deflated 51%)
updating: filter/doom.id/graphics/tntinter.lmp (172 bytes security) (deflated 78%)
updating: filter/doom.id/graphics/victory2.lmp (172 bytes security) (deflated 66%)
updating: filter/doom.id/graphics/wia20000.lmp (172 bytes security) (deflated 45%)
updating: filter/doom.id/graphics/wia20001.lmp (172 bytes security) (deflated 43%)
updating: filter/doom.id/graphics/wia20002.lmp (172 bytes security) (deflated 45%)
updating: filter/doom.id/graphics/wia20400.lmp (172 bytes security) (deflated 35%)
updating: filter/doom.id/graphics/wia20401.lmp (172 bytes security) (deflated 34%)
updating: filter/doom.id/graphics/wia20402.lmp (172 bytes security) (deflated 34%)
updating: filter/doom.id/graphics/wia20500.lmp (172 bytes security) (deflated 54%)
updating: filter/doom.id/graphics/wia20501.lmp (172 bytes security) (deflated 54%)
updating: filter/doom.id/graphics/wia20502.lmp (172 bytes security) (deflated 54%)
updating: filter/doom.id/graphics/wimap0.lmp (172 bytes security) (deflated 50%)
updating: filter/doom.id/graphics/wimap1.lmp (172 bytes security) (deflated 49%)
updating: filter/doom.id/graphics/wimap2.lmp (172 bytes security) (deflated 37%)
updating: filter/doom.id/sprites/SHT2E0.lmp (172 bytes security) (deflated 46%)
updating: filter/heretic.shadow/graphics/title.lmp (172 bytes security) (deflated 57%)
updating: filter/heretic/graphics/barback.lmp (172 bytes security) (deflated 49%)
updating: filter/heretic/graphics/credit.lmp (172 bytes security) (deflated 79%)
updating: filter/heretic/graphics/e2end.png (172 bytes security) (deflated 1%)
updating: filter/heretic/graphics/final1.lmp (172 bytes security) (deflated 68%)
updating: filter/heretic/graphics/final2.lmp (172 bytes security) (deflated 66%)
updating: filter/heretic/graphics/help1.lmp (172 bytes security) (deflated 82%)
updating: filter/heretic/graphics/help2.lmp (172 bytes security) (deflated 81%)
updating: filter/heretic/graphics/ltfctop.lmp (172 bytes security) (deflated 39%)
updating: filter/heretic/graphics/mape1.lmp (172 bytes security) (deflated 70%)
updating: filter/heretic/graphics/mape2.lmp (172 bytes security) (deflated 68%)
updating: filter/heretic/graphics/mape3.lmp (172 bytes security) (deflated 70%)
updating: filter/heretic/graphics/rtfctop.lmp (172 bytes security) (deflated 40%)
updating: filter/heretic/graphics/title.lmp (172 bytes security) (deflated 79%)
updating: filter/heretic/sprites/STFFC0.lmp (172 bytes security) (deflated 58%)
updating: filter/heretic/sprites/STFFH0.lmp (172 bytes security) (deflated 55%)
updating: filter/hexen.deathkings/graphics/credit.lmp (172 bytes security) (deflated 62%)
updating: filter/hexen.deathkings/graphics/help1.lmp (172 bytes security) (deflated 62%)
updating: filter/hexen.deathkings/graphics/help2.lmp (172 bytes security) (deflated 63%)
updating: filter/hexen.deathkings/graphics/title.lmp (172 bytes security) (deflated 68%)
updating: filter/hexen/graphics/credit.lmp (172 bytes security) (deflated 63%)
updating: filter/hexen/graphics/finale1.lmp (172 bytes security) (deflated 75%)
updating: filter/hexen/graphics/finale2.lmp (172 bytes security) (deflated 78%)
updating: filter/hexen/graphics/finale3.lmp (172 bytes security) (deflated 68%)
updating: filter/hexen/graphics/h2bar.lmp (172 bytes security) (deflated 62%)
updating: filter/hexen/graphics/h2top.lmp (172 bytes security) (deflated 59%)
updating: filter/hexen/graphics/help1.lmp (172 bytes security) (deflated 62%)
updating: filter/hexen/graphics/help2.lmp (172 bytes security) (deflated 63%)
updating: filter/hexen/graphics/interpic.lmp (172 bytes security) (deflated 77%)
updating: filter/hexen/graphics/title.lmp (172 bytes security) (deflated 71%)
updating: filter/hexen/sprites/CFLME0.lmp (172 bytes security) (deflated 45%)
updating: filter/hexen/sprites/CFLMF0.lmp (172 bytes security) (deflated 45%)
updating: filter/hexen/sprites/CMCEB0.lmp (172 bytes security) (deflated 60%)
updating: filter/hexen/sprites/CMCEC0.lmp (172 bytes security) (deflated 57%)
updating: filter/hexen/sprites/CMCED0.lmp (172 bytes security) (deflated 50%)
updating: filter/hexen/sprites/CMCEE0.lmp (172 bytes security) (deflated 51%)
updating: filter/hexen/sprites/FAXEB0.lmp (172 bytes security) (deflated 47%)
updating: filter/hexen/sprites/FAXEC0.lmp (172 bytes security) (deflated 43%)
updating: filter/hexen/sprites/FAXEN0.lmp (172 bytes security) (deflated 47%)
updating: filter/hexen/sprites/FAXEO0.lmp (172 bytes security) (deflated 43%)
updating: filter/hexen/sprites/FHMRB0.lmp (172 bytes security) (deflated 49%)
updating: filter/hexen/sprites/FHMRC0.lmp (172 bytes security) (deflated 46%)
updating: filter/hexen/sprites/FPCHB0.lmp (172 bytes security) (deflated 60%)
updating: filter/hexen/sprites/FPCHC0.lmp (172 bytes security) (deflated 52%)
updating: filter/hexen/sprites/FPCHD0.lmp (172 bytes security) (deflated 52%)
updating: filter/hexen/sprites/FPCHE0.lmp (172 bytes security) (deflated 53%)
updating: filter/hexen/sprites/FSRDD0.lmp (172 bytes security) (deflated 38%)
updating: filter/hexen/sprites/FSRDE0.lmp (172 bytes security) (deflated 32%)
updating: filter/hexen/sprites/FSRDH0.lmp (172 bytes security) (deflated 33%)
updating: filter/hexen/sprites/FSRDI0.lmp (172 bytes security) (deflated 36%)
updating: filter/hexen/sprites/MLNGG0.lmp (172 bytes security) (deflated 45%)
updating: filter/hexen/sprites/MLNGH0.lmp (172 bytes security) (deflated 44%)
updating: filter/hexen/sprites/MLNGI0.lmp (172 bytes security) (deflated 48%)
updating: .gitignore (172 bytes security) (stored 0%)
updating: credits.txt (172 bytes security) (deflated 51%)
updating: license.md (172 bytes security) (deflated 37%)
  adding: filter/ (192 bytes security) (stored 0%)
  adding: filter/doom.id/ (192 bytes security) (stored 0%)
  adding: filter/doom.id/graphics/ (192 bytes security) (stored 0%)
  adding: filter/doom.id/sprites/ (192 bytes security) (stored 0%)
  adding: filter/doom.id.doom1/ (192 bytes security) (stored 0%)
  adding: filter/doom.id.doom1/graphics/ (192 bytes security) (stored 0%)
  adding: filter/doom.id.doom1.registered/ (192 bytes security) (stored 0%)
  adding: filter/doom.id.doom1.registered/graphics/ (192 bytes security) (stored 0%)
  adding: filter/doom.id.doom1.shareware/ (192 bytes security) (stored 0%)
  adding: filter/doom.id.doom1.shareware/graphics/ (192 bytes security) (stored 0%)
  adding: filter/doom.id.doom1.ultimate/ (192 bytes security) (stored 0%)
  adding: filter/doom.id.doom1.ultimate/graphics/ (192 bytes security) (stored 0%)
  adding: filter/doom.id.doom2/ (192 bytes security) (stored 0%)
  adding: filter/doom.id.doom2/graphics/ (192 bytes security) (stored 0%)
  adding: filter/doom.id.doom2.plutonia/ (192 bytes security) (stored 0%)
  adding: filter/doom.id.doom2.plutonia/graphics/ (192 bytes security) (stored 0%)
  adding: filter/doom.id.doom2.tnt/ (192 bytes security) (stored 0%)
  adding: filter/doom.id.doom2.tnt/graphics/ (192 bytes security) (stored 0%)
  adding: filter/heretic/ (192 bytes security) (stored 0%)
  adding: filter/heretic/graphics/ (192 bytes security) (stored 0%)
  adding: filter/heretic/sprites/ (192 bytes security) (stored 0%)
  adding: filter/heretic.shadow/ (192 bytes security) (stored 0%)
  adding: filter/heretic.shadow/graphics/ (192 bytes security) (stored 0%)
  adding: filter/hexen/ (192 bytes security) (stored 0%)
  adding: filter/hexen/graphics/ (192 bytes security) (stored 0%)
  adding: filter/hexen/sprites/ (192 bytes security) (stored 0%)
  adding: filter/hexen.deathkings/ (192 bytes security) (stored 0%)
  adding: filter/hexen.deathkings/graphics/ (192 bytes security) (stored 0%)

C:\Projects\gzdoom2\wadsrc_widescreen\static>
I tested that specific archive and it has the changes. Make sure you're doing a git pull --recurse-submodules to receive the changes.

Or you can download my copy of the archive here: https://cdn.discordapp.com/attachments/ ... en_gfx.pk3

Re: Hexen: LFEDGE/RTEDGE drawn too high

by Graf Zahl » Fri May 21, 2021 3:32 pm

I did a 'git submodule update'. It looks like this was the only missing thing, though. I have all the rest of the new graphics.

Re: Hexen: LFEDGE/RTEDGE drawn too high

by Rachael » Fri May 21, 2021 3:14 pm

Did you do git pull --recurse?

It does not look bad to me.

Re: Hexen: LFEDGE/RTEDGE drawn too high

by Graf Zahl » Fri May 21, 2021 1:37 pm

Unfortunately this still doesn't look right. While the graphic has been fixed, the extended area of the main bar apparently has not - there's still a visible discontinuity to be observed.
As it stands I'll be holding off the release for the time being.

Re: Hexen: LFEDGE/RTEDGE drawn too high

by Rachael » Fri May 21, 2021 8:28 am

Added.

Re: Hexen: LFEDGE/RTEDGE drawn too high

by Nash » Fri May 21, 2021 8:10 am

Ok, done!

Re: Hexen: LFEDGE/RTEDGE drawn too high

by Nash » Fri May 21, 2021 7:47 am

Oh, no problem, I can fix it. Give me a moment.

Re: Hexen: LFEDGE/RTEDGE drawn too high

by Graf Zahl » Fri May 21, 2021 3:22 am

I'm going to wait with this until Nash responds. No need to do a release with incorrect assets.

Re: Hexen: LFEDGE/RTEDGE drawn too high

by Rachael » Fri May 21, 2021 2:55 am

If the widescreen graphics issue is reconciled, this pull request will fix this bug: https://github.com/coelckers/gzdoom/pull/1391

Top