Odd Crash w/ hw renderer, fog, and software lightmodes

Forum rules
Please don't bump threads here if you have a problem - it will often be forgotten about if you do. Instead, make a new thread here.

Post a reply

Smilies
:D :) :( :o :shock: :? 8-) :lol: :x :P :oops: :cry: :evil: :twisted: :roll: :wink: :geek: :ugeek: :!: :?: :idea: :arrow: :| :mrgreen: :3: :wub: >:( :blergh:
View more smilies
BBCode is OFF
Smilies are ON
Topic review
   

Expand view Topic review: Odd Crash w/ hw renderer, fog, and software lightmodes

Re: Odd Crash w/ hw renderer, fog, and software lightmodes

by drfrag » Mon Mar 29, 2021 8:21 am

I was going to make a PR but i wanted to ask first.

Re: Odd Crash w/ hw renderer, fog, and software lightmodes

by Rachael » Mon Mar 29, 2021 7:37 am

That is unmergeable because you decided to use the widescreen files directly instead of a submodule.

Please rebase this on a usable branch.

Nevermind I got it cherry-picked.

Re: Odd Crash w/ hw renderer, fog, and software lightmodes

by drfrag » Mon Mar 29, 2021 7:27 am

The map has the LEVEL_HASFADETABLE flag that's why it crashes. What about just adding null pointer checks?
https://github.com/drfrag666/gzdoom/com ... 9da4fc7104

Re: Odd Crash w/ hw renderer, fog, and software lightmodes

by drfrag » Tue Mar 23, 2021 6:10 am

It's pretty much the same code as in the old renderer and the only difference i see it's in the call. Here the parameter is di->isFullbrightScene() and before it was FixedColormap != CM_DEFAULT.

Re: Odd Crash w/ hw renderer, fog, and software lightmodes

by _mental_ » Sat Mar 20, 2021 8:17 am

It crashes inside HWDrawInfo::SetFog() because cmap is null when it's called from HWWall::RenderTexturedWall() function.

Odd Crash w/ hw renderer, fog, and software lightmodes

by Alper002 » Fri Mar 19, 2021 1:45 pm

The crash seems to only happen using the hardware renderer (no matter the rendering API, I've tried opengl, vulkan, and softpoly2d), while also using build, software, or vanilla lightmodes.

In the attached wad I've compiled there are 3 extremely similar maps for Hexen replacing MAP08, MAP11, and MAP12.
MAP11 is a setup which crashes when settings are set in the way described. Trying to look into the next room causes the crash window to pop up.
MAP08 has only one difference and doesn't crash with those settings.
MAP12 is identical to MAP11, but is on a map whose MAPINFO isn't foggy, which seems to make it not crash.
I've been testing on 4.5.0.
Attachments
CrashReport.zip
A report of crashing on MAP11
(36.4 KiB) Downloaded 23 times
WeirdGeoCrash.wad
The wad file in question
(49.75 KiB) Downloaded 23 times

Top