Welcome to the ZDoom Forums!

[quote="Graf Zahl"]The idea is to do what Raze does and offer [u]multiple preset configurations[/u] but it hasn't been defined yet in GZDoom.
[/quote]


Sweeeeeeeeet. :D

That's really weird. It worked out in the end I suppose.

I dunno what was different.

Well done. For me Control and Shift didn't work due to the name change but i could not reproduce the issue with mouse2 and i was using your test as an iwad.

My friends always did tell me I was wordy XD

Pleasure helping you fix this Graf.

It could be shortened a bit, but who cares? ;) Yes, this is ok.

Done and done, boss.

Let me know if it needs to be revised.

Yes, that's correct. Can you copy it to the other loop in there as well? That also needs to be protected. Right now I'm at work and cannot do it myself.

https://github.com/coelckers/gzdoom/pull/1075

I used the code you supplied and tested it. It doesn't overwrite the settings if it's loaded from a standard WAD or PK3. However, if it loads from an IWAD/IPK3/IPK7, it will.

Tested with the following files:

https://www.dropbox.com/s/0jehjgtq9cs8qw4/defbinds-test.pk3?dl=1 Is just a dummy PK3 with a DEFBINDS in it and nothing more.

https://www.dropbox.com/s/h3193g4rsspadgs/defbinds-test-IPK3.ipk3?dl=1 is an IPK3 with a typical IPK3 setup - DEFBINDS, CVARDEFS, palette, IWADINFO.

I think I have something that'll work better. I did a test with a dummy PK3 and it doesn't override the settings.

		if (fileSystem.GetFileContainer(i) > fileSystem.GetMaxIwadNum()) ...

Sure:

[code]
if (fileSystem.GetFileContainer(i) > fileSystem.GetMaxIwadNum()) ...
[/code]
If that is true you are in a user mod.

is there an internal filesystem function that allows me to sort DEFBINDS based on where they came from?

When reading the bindings file there needs to be an origin check, if it comes from the IWAD or an internal definition it should be allowed, otherwise not.

Ah, my bad.

This might require someone smarter than me, but it seems the logical thing would be to check and see if the DEFBINDS is being loaded by an IWAD or an IPK3 or an IPK7.

Sorry, but that's not a proper fix - the protection for user-side bindings needs to be present, otherwise a malicious PWAD can nuke your entire setup.

https://github.com/coelckers/gzdoom/pull/1074

Pushed a pull request.