ZDoom

I see, performance here apparently is the same too. We could change it then.

If you saw a difference, it would be broken. The idea is performance, not visual improvement.

Heh, in theory i should know. Remember that technically i'm a technical engineer AKA half-assed engineer which is the middle category for computer science in Spain, unfortunately formation was mostly theorical at university. So it was that thing, now i remember. :)
Anyway it seems it's not worth changing it, do you see any difference? I don't.

[quote="drfrag"]I don't know but with g_sindeg the effect doesn't work.[/quote]
drfrag do you know what Radians are?
[imgur]https://imgur.com/Q8tCdse[/imgur]

It's the natural calculations that occur from the actual trig formulae when applied to a real triangle. 360 degrees is pi * 2 radians.

That is why attempting to use a "degrees" function in a formula designed for "radians" does not work. Radians are a unit of angles that are different than Degrees.

Of course not, the code was written for radians.

I don't know but with g_sindeg the effect doesn't work.

[quote="drfrag"]Isn't g_sindeg for radians?[/quote]

No, as the name suggests, g_sindeg is for degrees. The way the table is set up, this saves a multiplication if the values being used already are in degrees, as is the case for all in-game angles.

I've tried with g_sin and i can't tell the difference.

Isn't g_sindeg for radians?

None, save for precision related issues once the numbers get too large to represent all the fractional digits.

[quote="Graf Zahl"]g_sin and g_sindeg are the ones that should be used, depending on what value range the angle is in.[/quote]
What are the range limits?

[quote="drfrag"]It's pretty much the same, i edited BD to test it.[/quote]
Thanks.

g_sin and g_sindeg are the ones that should be used, depending on what value range the angle is in.

There are a lot of them: sin, g_sin, fastsin, c_sin...

[quote="dpJudas"]I added the warp effect. Note that the sin there should probably be done by some lookup table (don't know if gzdoom's sin already does that or not).[/quote]


The sine function already uses a lookup table, combined with linear interpolation - provided you use the correct one. This one's roughly 2-3x faster than the regular C-function 'sin'. For rendering a warped texture it may be useful to add an uninterpolated variant, of course