ZDoom

Ah, thanks. I didn't know getenv was part of the standard library. Will try that.

if (NicePath("$XDG_CONFIG_HOME/").IsEmpty())

The main issues I see are places where you make a call like:
[code]if (NicePath("$XDG_CONFIG_HOME/").IsEmpty())[/code]
Even if XDG_CONFIG_HOME is empty or unset, the returned path would still contain an / which means it'll never be an empty result. Also a number of times you seem to make multiple NicePath calls with XDG_CONFIG_HOME as the base to test if it's set (this isn't performance-sensitive code, but still). A simple getenv should work, testing if it returns NULL or an empty string.

Relatedly, there is also a $XDG_CACHE_HOME in the XDG standard (with a fallback to $HOME/.cache), which might be better to use instead of "$XDG_CONFIG_HOME/zdoom/cache" or "$HOME/.config/zdoom/cache".

[quote]We use GitHub pull requests for code contributions.[/quote]

Yeah, I already submitted a pull request for another issue, but didn't in this case since this patch doesn't work (yet). I can clean it up and submit it, though.

I think in most cases, $XDG_CONFIG_HOME is not defined, but the spec states "$XDG_CONFIG_HOME defines the base directory relative to which user specific configuration files should be stored. If $XDG_CONFIG_HOME is either not set or empty, a default equal to $HOME/.config should be used.".

We use GitHub pull requests for code contributions.
While small patches can be accepted, it's much easier to comment and review changes in PR.

For example, this patch cannot be used as is because:[list][*]It uses C++ IO streams for logging and it's pretty useless anyway in my opinion[*]It alters error reporting in a bad way and two consecutive I_FatalError() calls are simply wrong[/list]
Ubuntu versions I tried have no [b]$XDG_CONFIG_HOME[/b] defined but only [b]$XDG_CONFIG_DIRS[/b] environment variable.

if (mkdir

GZDoom should use the path defined in the environment variable XDG_CONFIG_HOME and if it's not defined, fall back to ~/.config. Cf. the XDG Base Directory Specification: https://standards.freedesktop.org/basedir-spec/basedir-spec-latest.html

This makes it easier to package. I've tried to fix this myself, but somehow configPath still contains ~/.config in the [code]if (mkdir[/code] block even if it should contain the value of the environment variable.
Examples of XDG_CONFIG_HOME usage:

https://github.com/chocolate-doom/chocolate-doom/commit/d1d65f2567d4943e2103414e793b0e445e6365d5
https://github.com/Novum/vkQuake/pull/116/files

My patch:
[spoiler][code]From f3c4d5a2cb8a210b076caf78d4d36202fc6fe898 Mon Sep 17 00:00:00 2001
From: toxicbits
Date: Thu, 8 Mar 2018 21:43:54 +0100
Subject: [PATCH] Use XDG_CONFIG_HOME if it's defined

---
src/posix/unix/i_specialpaths.cpp | 27 ++++++++++++++++++++++-----
1 file changed, 23 insertions(+), 5 deletions(-)

diff --git a/src/posix/unix/i_specialpaths.cpp b/src/posix/unix/i_specialpaths.cpp
index 60cc12fcf..61ff54a3c 100644
--- a/src/posix/unix/i_specialpaths.cpp
+++ b/src/posix/unix/i_specialpaths.cpp
@@ -40,6 +40,7 @@

#include "version.h" // for GAMENAME

+#include <iostream>

FString GetUserFile (const char *file)
{
@@ -53,12 +54,22 @@ FString GetUserFile (const char *file)
struct stat extrainfo;

// Sanity check for $HOME/.config
- FString configPath = NicePath("$HOME/.config/");
+ FString pathString = "$XDG_CONFIG_HOME";
+ std::cout << "NicePath(pathString).GetChars(): " << NicePath(pathString).GetChars() << std::endl;
+ if (NicePath("$XDG_CONFIG_HOME").IsEmpty())
+ {
+ std::cout << "$XDG_CONFIG_HOME was empty" << std::endl; pathString = "$HOME/.config/";
+ }
+ std::cout << "NicePath(pathString).GetChars():" << NicePath(pathString).GetChars() << std::endl;
+ FString configPath = NicePath(pathString);
+ std::cout << "configPath.GetChars(): " << configPath.GetChars() << std::endl;
if (stat (configPath, &extrainfo) == -1)
{
if (mkdir (configPath, S_IRUSR | S_IWUSR | S_IXUSR) == -1)
{
- I_FatalError ("Failed to create $HOME/.config directory:\n%s", strerror(errno));
+ std::cout << configPath.GetChars() << std::endl;
+ I_FatalError ("Failed to create %s directory:\n%s <- pathString", pathString.GetChars(), strerror(errno));
+ I_FatalError ("Failed to create %s directory:\n%s <- configPath", configPath.GetChars(), strerror(errno));
}
}
else if (!S_ISDIR(extrainfo.st_mode))
@@ -80,7 +90,6 @@ FString GetUserFile (const char *file)
else
moved = true;
}
-
if (!moved && mkdir (path, S_IRUSR | S_IWUSR | S_IXUSR) == -1)
{
I_FatalError ("Failed to create %s directory:\n%s",
@@ -110,7 +119,11 @@ FString M_GetAppDataPath(bool create)
{
// Don't use GAME_DIR and such so that ZDoom and its child ports can
// share the node cache.
- FString path = NicePath("$HOME/.config/" GAMENAMELOWERCASE);
+ FString path = NicePath("$XDG_CONFIG_HOME/" GAMENAMELOWERCASE);
+ if (NicePath("$XDG_CONFIG_HOME/").IsEmpty())
+ {
+ path = NicePath("$HOME/.config/" GAMENAMELOWERCASE);
+ }
if (create)
{
CreatePath(path);
@@ -130,7 +143,11 @@ FString M_GetCachePath(bool create)
{
// Don't use GAME_DIR and such so that ZDoom and its child ports can
// share the node cache.
- FString path = NicePath("$HOME/.config/zdoom/cache");
+ FString path = NicePath("$XDG_CONFIG_HOME/zdoom/cache");
+ if (NicePath("$XDG_CONFIG_HOME/").IsEmpty())
+ {
+ path = NicePath("$HOME/.config/zdoom/cache");
+ }
if (create)
{
CreatePath(path);
--
2.14.3

[/code][/spoiler]