ZDoom

Thanks for applying this. This can be closed.

I'm gonna stick with Graf's route and not fix what isn't broken. As for the name... :shrug:

I'm not convinced about the variable name, but dunno about any other 'alternative' ones. I wonder if it would be better to condense all the morph data into a struct or class...

[url=https://github.com/rheit/zdoom/pull/786]Bugfix PR. Things turned out to be a tad bit different -- but for good reason.[/url]

Tracer is not a safe pointer at all anymore, for storing players and their morphed counterparts. Why? A_RearrangePointers just to name one. The easiest thing to do for players is to introduce the 'alternative' pointer into the mix. I've thus removed all form of storing (un)morphed tracers in the players and morphs [b]involving the morph swappage[/b], and is now done through the alternative pointer.

Monsters remain unchanged: they have an (Un)MorphedMe pointer and aren't of concern.

This fixes several things, and does me a bonus favor:

[list]
[*]Fixes the crash experienced here.
[*]Fixes a long outstanding bug that only I was able to reproduce a long time ago involving morphs failing to unmorph due to the player tracer pointer being manipulated (Do an A_RadiusGive to all playerpawns which causes them to forget their tracers... That unmorph is never coming!)
[*]The original target and tracer are now transferred forth for maintained consistency and better tracking of pointers. When the morph expires, it transfers the target and tracer back which may or may not have changed over time, again for consistency.[/list]

Yeah, you can go ahead.

I believe target and master should also do the same thing because I could have been using SXF_ISTARGET as well.

Alright. I'll work on it, if edward isn't.

No. There's only a flag on the unmorphed version, but you need tracer to get there. My solution here would be simple:

Add a new variable and set the unmorphed monster both as that and as tracer. I think that will solve all potential issues.

[quote="Graf Zahl"]Correct. Since it's no longer safe to use tracer for this, a different variable is needed.[/quote]

Is there a particular property or flag that's set on a morphed actor to safely check, to transition them into a MorphedTarget/Master/Tracer?

I hope there's nothing which (ab)used the morphed tracer data...

[quote="Edward-san"]
In order to fix this, I suspect the old actor pointer should be stored in a different place than the 'tracer'. Graf?[/quote]

Correct. Since it's no longer safe to use tracer for this, a different variable is needed.

	Spawn:
		PLAY A 95 NoDelay
		{
			SetPlayerProperty(0,1,PROP_TOTALLYFROZEN);
			A_PrintBold("Camera On");
			A_SpawnItemEx("ChaseCam",-10,0,32,0,0,0,0,SXF_NOCHECKPOSITION|SXF_SETMASTER|SXF_ISTRACER,0,32700);
			ChangeCamera(32700,0,0);
		}
		PLAY A 0
		{
			A_RemoveChildren(true,RMVF_EVERYTHING,"ChaseCam");
		}

I tested it again just to make sure:

[code] Spawn:
PLAY A 95 NoDelay
{
SetPlayerProperty(0,1,PROP_TOTALLYFROZEN);
A_PrintBold("Camera On");
A_SpawnItemEx("ChaseCam",-10,0,32,0,0,0,0,SXF_NOCHECKPOSITION|SXF_SETMASTER|SXF_ISTRACER,0,32700);
ChangeCamera(32700,0,0);
}
PLAY A 0
{
A_RemoveChildren(true,RMVF_EVERYTHING,"ChaseCam");
}[/code]

This doesn't crash, backing up Edward's words possibly.

			A_SpawnItemEx("ChaseCam",-10,0,32,0,0,0,0,SXF_NOCHECKPOSITION|SXF_SETMASTER|SXF_ISTRACER,0,32700);

	if (flags & SIXF_ISTRACER)
	{
		self->tracer = mo;
	}

It seems that this line in decorate.txt:

[code]
A_SpawnItemEx("ChaseCam",-10,0,32,0,0,0,0,SXF_NOCHECKPOSITION|SXF_SETMASTER|SXF_ISTRACER,0,32700);
[/code]

makes sure that the morphed actor's tracer, which points to the actor before morphing, is overridden with the camera:

[code]
if (flags & SIXF_ISTRACER)
{
self->tracer = mo;
}
[/code]
from InitSpawnedItem, called by A_SpawnItemEx.

The old actor's information is lost, making the program crash when attempting to unmorph, because it's trying to get the player's info from invalid actor.

In order to fix this, I suspect the old actor pointer should be stored in a different place than the 'tracer'. Graf?

Okay, first post updated. User variables removed.

Can you add a test wad which does just morph and unmorph? In a post above, I mentioned a problem with those steps and would like to check it again.

Meh.

Anyway, anything else I can try to do for this? Or is this something randi has to look into?