by edward850 » Mon Jul 20, 2015 11:18 pm
Lacking an example, I can't actually test this, but I have noticed a potential logical hole. While all monsters can have MF_CORPSE, so can anything that dies with a raise state (thanks Batman Doom), and players.
More over, RGF_CORPSES on its own wont actually include anything, so you still need to check for another flag type. RGF_MONSTERS is required to check for all corpses of monsters, but the kicker here is it also means that normal monsters are also inclusive. Something tells me this isn't what you want, and the flag check logic here is rather poorly designed.
... Almost as if it was never actually tested.
Lacking an example, I can't actually test this, but I have noticed a potential logical hole. While all monsters can have MF_CORPSE, so can anything that dies with a raise state (thanks Batman Doom), and players.
More over, RGF_CORPSES on its own wont actually include anything, so you still need to check for another flag type. RGF_MONSTERS is required to check for all corpses of monsters, but the kicker here is it also means that normal monsters are also inclusive. Something tells me this isn't what you want, and the flag check logic here is rather poorly designed.
... Almost as if it was never actually tested.