[gef2fa6487 regression]ANIMDEFS error on load

Forum rules
Please don't bump threads here if you have a problem - it will often be forgotten about if you do. Instead, make a new thread here.

Post a reply

Smilies
:D :) :( :o :shock: :? 8-) :lol: :x :P :oops: :cry: :evil: :twisted: :roll: :wink: :geek: :ugeek: :!: :?: :idea: :arrow: :| :mrgreen: :3: :wub: >:( :blergh:
View more smilies

BBCode is OFF
Smilies are ON

Topic review
   

Expand view Topic review: [gef2fa6487 regression]ANIMDEFS error on load

Re: [gef2fa6487 regression]ANIMDEFS error on load

by Graf Zahl » Sun Jan 12, 2020 4:12 pm

I mean, since when was the bug in the code that _mental_ fixed. This is old stuff that has always been there, I just replaced the existing directory scanner in the WAD manager.

Re: [gef2fa6487 regression]ANIMDEFS error on load

by drfrag » Sun Jan 12, 2020 4:05 pm

Since "- fixed: The directory scanner for reading a directory into the WAD file system and ScanDirectory were not Unicode capable on Windows." i think.

Re: [gef2fa6487 regression]ANIMDEFS error on load

by Graf Zahl » Sun Jan 12, 2020 3:22 pm

Ugh. How long has that bug been there? It apparently never got noticed because that code wasn't used for critical operations before.

Re: [gef2fa6487 regression]ANIMDEFS error on load

by _mental_ » Sun Jan 12, 2020 3:06 pm

It had nothing to do with ANIMDEFS. It's just directory traversal was broken on non-Windows platforms. Fixed in 7092a0a.

[gef2fa6487 regression]ANIMDEFS error on load

by Edward-san » Sun Jan 12, 2020 1:52 pm

When I run gzdoom with DoomRPG, I get this error which didn't appear before the directory fix commit:

Code: Select all

*lots of warnings*

ANIMDEFS: Can't find FIRESK00
2020-01-12 20:47:24.460793+0100 gzdoom[30046:3204639] Script error, ":animdefs.txt" line 11:
Unknown texture FIRESK99
Command line to run:

Code: Select all

gzdoom -iwad DOOM2.WAD -file DoomRPG/DoomRPG

I suppose this can only be reproduced if the DoomRPG source at github is downloaded in the wads path.

[edit]Full log before and after the change:
Spoiler: before
Spoiler: after
so the number of warnings increased drastically.

Top