ZDoom

fixed

let barmor = BasicArmor(Spawn('BasicArmor'));
barmor.BecomeItem ();
AddInventory (barmor);

GiveInventoryType('BasicArmor');

In my opinion, [url=https://github.com/coelckers/gzdoom/blob/2d1c7ba17cac3ccd201e77ad01a9dd06ab22cb2e/wadsrc/static/zscript/actors/player/player.zs#L1837-L1839]these lines[/url][code]let barmor = BasicArmor(Spawn('BasicArmor'));
barmor.BecomeItem ();
AddInventory (barmor);[/code]
should be replaced with
[code]GiveInventoryType('BasicArmor');[/code]
It's the same thing that already works for Hexen armor.

[s]Hmm. In that case maybe change ClearInventory() to DestroyAllInventory() [url=https://github.com/coelckers/gzdoom/blob/04334aa0fe01e35d853563b0126dab6792f6d67e/wadsrc/static/zscript/actors/player/player.zs#L2055]here[/url]?[/s]
[EDIT]Nevermind. I think mental has the right approach.[/EDIT]

Again, I found out about this without any custom PlayerPawn actors.

This function was actually never meant to be called on a PlayerPawn with an initialized inventory. It really should clear the entire inventory before doing its stuff.

IE it gives another one without checking if the player already has one.
[url]https://github.com/coelckers/gzdoom/blob/2d1c7ba17cac3ccd201e77ad01a9dd06ab22cb2e/wadsrc/static/zscript/actors/player/player.zs#L1837[/url]

I only noticed this while playing a mapset that utilizes ResetInventory in its MAPINFO by typing printinv right after finishing a map (was testing stuff) and seeing multiple BasicArmors being listed.

As I understand it, there should be only one "BasicArmor" in the inventory chain at any time.

Quick edit: was testing in 4.1.3