[4.0] dithered SSAO in Vulkan

Forum rules
Please don't bump threads here if you have a problem - it will often be forgotten about if you do. Instead, make a new thread here.

Post a reply

Smilies
:D :) :( :o :shock: :? 8-) :lol: :x :P :oops: :cry: :evil: :twisted: :roll: :wink: :geek: :ugeek: :!: :?: :idea: :arrow: :| :mrgreen: :3: :wub: >:( :blergh:
View more smilies

BBCode is OFF
Smilies are ON

Topic review
   

Expand view Topic review: [4.0] dithered SSAO in Vulkan

Re: [4.0] dithered SSAO in Vulkan

by dpJudas » Tue Apr 16, 2019 8:19 am

This one should be fixed now. Rewrote the entire shader to workaround whatever it was that (apparently) broke NVidia's driver.

Re: [4.0] dithered SSAO in Vulkan

by dpJudas » Tue Apr 16, 2019 5:19 am

Thanks _mental_. That confirms it is a NVidia issue since debug 1 seems to have blured it just fine.

Re: [4.0] dithered SSAO in Vulkan

by _mental_ » Tue Apr 16, 2019 2:53 am

RX Vega 64, gl_ssao_debug 1
amd_gl_ssao_debug_1.png
gl_ssao_debug 2
amd_gl_ssao_debug_2.png

Re: [4.0] dithered SSAO in Vulkan

by dpJudas » Tue Apr 16, 2019 1:51 am

No, I only own a computer with a NVidia card. The disassembly in RenderDoc seem to indicate the GLSL compiler itself is generating valid output, but maybe the SPIR-V compiler (in the driver) breaks.

If someone with a Intel or AMD card could take a screenshot with gl_ssao_debug 1 and gl_ssao_debug 2 output that'd be appreciated (latest vulkan2 branch build, not 4.0).

Re: [4.0] dithered SSAO in Vulkan

by Graf Zahl » Tue Apr 16, 2019 1:38 am

Have you been able to cross-check this with someone on Intel or AMD hardware? It may also be a problem with the GLSL compiler and not the driver.

Re: [4.0] dithered SSAO in Vulkan

by dpJudas » Tue Apr 16, 2019 1:16 am

Seems this one is going to be hard to fix. Spent hours on it now getting absolutely nowhere. Every type of debugging I've done says the input to the depthblur shader is correct. Yet, somehow in OpenGL mode it works but in Vulkan mode it doesn't.

To make it even weirder, if I hardcode the push constant values in the shader the Vulkan version also works. Yet RenderDoc says the values I push are the correct and same values.. At this point I've started to wonder if it is a Nvidia driver bug. :(

Re: [4.0] dithered SSAO in Vulkan

by Nash » Mon Apr 15, 2019 12:26 pm

Use gl_texture 0 to turn off the level textures. :D

Re: [4.0] dithered SSAO in Vulkan

by dpJudas » Mon Apr 15, 2019 9:13 am

Seems the depth blur isn't applied for some reason. How did you create those pictures? Not using the debug cvars I hope. :)

[4.0] dithered SSAO in Vulkan

by Nash » Mon Apr 15, 2019 3:38 am




(Click to see full resolution image)

Top: OpenGL
Bottom: Vulkan

SSAO appears to look dithered in Vulkan. I am using the "low" setting (gl_ssao = 1)

Top