[Master] VM Abort when shooting a barrel in Harmony

Forum rules
Please don't bump threads here if you have a problem - it will often be forgotten about if you do. Instead, make a new thread here.

Post a reply

Smilies
:D :) :( :o :shock: :? 8-) :lol: :x :P :oops: :cry: :evil: :twisted: :roll: :wink: :geek: :ugeek: :!: :?: :idea: :arrow: :| :mrgreen: :3: :wub: >:( :blergh:
View more smilies

BBCode is OFF
Smilies are ON

Topic review
   

Expand view Topic review: [Master] VM Abort when shooting a barrel in Harmony

Re: [Master] VM Abort when shooting a barrel in Harmony

by _mental_ » Sat Jan 12, 2019 4:22 am

Fixed in e353201.

Re: [Master] VM Abort when shooting a barrel in Harmony

by Graf Zahl » Sat Jan 12, 2019 3:46 am

The other checks would be crash issues, but that particular one needs to be disable for Dehacked-modified states, because the non-Actor functions that can be set here would otherwise cause an abort. All Dehacked-usable functions should contain enough safety checks to not crash.

Re: [Master] VM Abort when shooting a barrel in Harmony

by _mental_ » Sat Jan 12, 2019 2:53 am

Is it about disabling of this check if the state was modified by Dehacked? Or is it about a whole FState::CheckCallerType() function?

Re: [Master] VM Abort when shooting a barrel in Harmony

by Graf Zahl » Mon Jan 07, 2019 8:39 am

While the check is correct, it needs to be disabled if a state gets modified by Dehacked.

Re: [Master] VM Abort when shooting a barrel in Harmony

by _mental_ » Mon Jan 07, 2019 8:24 am

The issue was introduced in this commit. It affects 3.7 release too.

[Master] VM Abort when shooting a barrel in Harmony

by Rachael » Mon Jan 07, 2019 1:34 am



Harmony is available here

When shooting any of the "ExplosiveBarrel" types in Harmony, a VM abort is immediately caused. This happens even with +vm_jit 0.

Top