SPC Music No Longer Loops Properly

Forum rules
Please don't bump threads here if you have a problem - it will often be forgotten about if you do. Instead, make a new thread here.

Post a reply

Smilies
:D :) :( :o :shock: :? 8-) :lol: :x :P :oops: :cry: :evil: :twisted: :roll: :wink: :geek: :ugeek: :!: :?: :idea: :arrow: :| :mrgreen: :3: :wub: >:( :blergh:
View more smilies

BBCode is OFF
Smilies are ON

Topic review
   

Expand view Topic review: SPC Music No Longer Loops Properly

Re: SPC Music No Longer Loops Properly

by _mental_ » Sat Dec 29, 2018 10:13 am

Probably you are right. Unfortunately, this won't help much. The thing is I'm pretty sure it will be overwritten like many other custom changes in thirdparty libraries. That GME update is a good example of this, but certainly it wasn't the first one.

Re: SPC Music No Longer Loops Properly

by Edward-san » Sat Dec 29, 2018 9:58 am

Why not adding a TODO comment stating this? At least it makes sure we don't miss this the next time gme is updated.

Re: SPC Music No Longer Loops Properly

by _mental_ » Sat Dec 29, 2018 8:48 am

I was searching for SPC changes in GME repository and found that commit with 'This is a behavior change' in its message. Indeed, its removal fixes the problem.
Actually, it could require some modifications in our codebase to work properly, but I have no idea how to handle it. I believe it's better to revert one commit than a whole GME update.

Re: SPC Music No Longer Loops Properly

by Graf Zahl » Sat Dec 29, 2018 7:55 am

How did you find that?

Re: SPC Music No Longer Loops Properly

by _mental_ » Sat Dec 29, 2018 7:50 am

Fixed in df2bef2.

Re: SPC Music No Longer Loops Properly

by drfrag » Tue Dec 18, 2018 11:20 am

Good. Wohlstand did the update so i think he's the man for the job.

Re: SPC Music No Longer Loops Properly

by Rachael » Tue Dec 18, 2018 10:42 am

Yeah, they are. Done.

Re: Broken SPC music looping

by Graf Zahl » Tue Dec 18, 2018 10:25 am

If it's the same bug they should be merged.

Re: Broken SPC music looping

by Rachael » Tue Dec 18, 2018 10:19 am

viewtopic.php?f=104&t=62613

This is a duplicate, however it provides additional information. Graf, would you be opposed to me merging these two topics because I think they both independently provide additional info into the bug that the other doesn't (the other one for example has a plain example), rather than closing one off?

Broken SPC music looping

by drfrag » Tue Dec 18, 2018 9:04 am

Since ""Update GME up to 0.6.2 version". Tested with DOOM SNES Jukebox - Ultra pack!: viewtopic.php?f=46&t=49073

Original report: viewtopic.php?f=231&t=62157&start=15#p1084022

SPC Music No Longer Loops Properly

by Guest » Mon Nov 19, 2018 3:16 pm

This may impact other emulated musics, but this is confirmed to be affecting SPC's. Instead of playing endlessly, SPC tracks will start again from the beginning. The linked piece of music helps make this obvious: http://edthebat.com/doom/spctest.pk3

The brief musical sting should only play at the beginning, and then the song should run continuously, but now it starts again from the sting after about 20 seconds.

I can't confirm when this began, but I know GZDoom's version of GME was modified in the past few weeks, so I have suspicions about that. It is confirmed to be happening as late as Nov 19's devbuild: g3.7pre-266-g426ee2b78 (64-bit)

Top