[g3.4pre-419-gbcadd2bf0-m] Crash after taking a screenshot

Forum rules
Please don't bump threads here if you have a problem - it will often be forgotten about if you do. Instead, make a new thread here.

Post a reply

Smilies
:D :) :( :o :shock: :? 8-) :lol: :x :P :oops: :cry: :evil: :twisted: :roll: :wink: :geek: :ugeek: :!: :?: :idea: :arrow: :| :mrgreen: :3: :wub: >:( :blergh:
View more smilies
BBCode is OFF
Smilies are ON
Topic review
   

Expand view Topic review: [g3.4pre-419-gbcadd2bf0-m] Crash after taking a screenshot

Re: [g3.4pre-419-gbcadd2bf0-m] Crash after taking a screensh

by _mental_ » Sat May 19, 2018 3:07 am

No, it's not. Fixed in ace5ee3.

Re: [g3.4pre-419-gbcadd2bf0-m] Crash after taking a screensh

by Cacodemon345 » Fri May 18, 2018 9:51 am

It should be fixed.

Re: [g3.4pre-419-gbcadd2bf0-m] Crash after taking a screensh

by _mental_ » Thu May 17, 2018 9:24 am

It's just an incorrect address passed to delete. Graf was a bit too aggressive with code removal in this commit.

Re: [g3.4pre-419-gbcadd2bf0-m] Crash after taking a screensh

by ketmar » Thu May 17, 2018 9:14 am

1. it is absolutely safe to call `delete` on null pointer — by the c++ specs.
2. it is inside `if (buffer != NULL)` check anyway, isn't it?

it looks like there is a buffer overrun somewhere in another code, and glibc's memory allocator structs are corrupted.

[g3.4pre-419-gbcadd2bf0-m] Crash after taking a screenshot

by Marisa the Magician » Thu May 17, 2018 8:32 am

Anytime I take a screenshot gzdoom crashes with the message "munmap_chunk(): invalid pointer", I've tracked it down to line 644 of m_misc.cpp.

Guess you forgot a check for null before calling delete on the screenshot buffer.

Top